Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 465627

Summary:	Unit tests for orion.edit.command failing
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Editor	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti
Version:	8.0
Target Milestone:	9.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2015-04-27 16:36:26 EDT

These orion.edit.command tests started failing in build #754 when the split editors branch was merged into master:

* js_tests_ui_uiTests.orion_edit_command _run() (legacy).should open frame when command returns 'uriTemplate' field
* js_tests_ui_uiTests.orion_edit_command _run() (legacy).should set status when command returns 'status' field
* js_tests_ui_uiTests.orion_edit_command _run() (legacy).should set editor text when command returns 'text' field
* js_tests_ui_uiTests.orion_edit_command _run() (legacy).should set editor text when command returns a string
* js_tests_ui_uiTests.orion_edit_command _run() (legacy).should set editor selection when command returns 'selection' field
* js_tests_ui_uiTests.orion_edit_command _execute().#openDelegatedUI() should open iframe
* js_tests_ui_uiTests.orion_edit_command _execute().iframe should be able to set status

I have not checked the functionality to see if the features themselves are broken, or if the tests/mock objects are just out of date.

[1] https://hudson.eclipse.org/orion/job/orion-client-dev/754/#showFailuresLink

Comment 1 Mark Macdonald

2015-04-28 10:11:30 EDT

Some changes happened in editorCommands.js which the tests had to react to. The features themselves were OK.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5c736bb