Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 465334

Summary:	[esprima] Exception trying to propose assist on incomplete short-hand if statement
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	8.0
Target Milestone:	9.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Michael Rennie

2015-04-23 13:40:08 EDT

Consider the following snippet:

this.linkedstyle = context.linkedData.style ? conte^[assist here]

You get the following exception:

c (walk.js:28)
skipThrough (walk.js:163)
c (walk.js:29)
base.ExpressionStatement (walk.js:176)
c (walk.js:29)
skipThrough (walk.js:163)
c (walk.js:29)
base.Program.base.BlockStatement (walk.js:171)
c (walk.js:29)
exports.simple (walk.js:32)
postParse (doc_comment.js:28)
runPasses (infer.js:1158)
exports.parse (infer.js:1177)
updateText (tern.js:79)
clearFile (tern.js:271)
ensureFile (tern.js:234)
doRequest (tern.js:184)
signal.mixin.request (tern.js:141)
computeProposals (ternAssistHandler.js:360)
onmessage (ternWorker.js:114)

Comment 1 Michael Rennie

2015-04-28 09:39:22 EDT

Fix + tests:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3e7b2da08df65cc284b920e4dd2ebeec58595557

Also fixes up the JS Tern tests to properly time out as needed