Bugzilla – Full Text Bug Listing
| Summary: | Icon enhancement in the application model editor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Olivier Prouvost <olivier.prouvost> | ||||
| Component: | UI | Assignee: | Olivier Prouvost <olivier.prouvost> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, dirk.fauth, Lars.Vogel, olivier.prouvost, simon.scholz, yxiaobo | ||||
| Version: | 4.5 | Flags: | daniel_megert:
pmc_approved+
|
||||
| Target Milestone: | 4.5.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X | ||||||
| See Also: |
https://git.eclipse.org/r/46354 https://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=0772fbb9bd0838f083e04a095bf3362136dd5278 https://git.eclipse.org/r/53919 https://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=e59968c4739b901833550e1f4fe71b33b64fa29f |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 475203 | ||||||
| Attachments: |
|
||||||
|
Description
Olivier Prouvost
New Gerrit change created: https://git.eclipse.org/r/46354 WARNING: this patchset contains 1279 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire I get frequently crashes with this change and 4.5.0.I20150506-2000. This might not the due to this change, but to some PDE issues which should be solved with 4.5.0.I20150507-2000. I try it again tomorrow or next week. Can you also attach a screenshot how it should look like? The icons for the parts do for example not show the select icon in the tree. From a email you send me, I expected that. Created attachment 253325 [details]
Icons in the editor
Even with this change, the icons are not displayed correct, see screenshot. The example is based on the Eclipse 4 template and the window has an icon assigned, via platform:/plugin/test/icons/sample.png
This bug has been fixed with a the review https://git.eclipse.org/r/#/c/46354/ which has not been merged.. I will recheck it again but it should not be a big issue... Thanks Olivier, works fine with 4.5.0.I20150510-2000. The errors I was seeing were most likely related to the icon replacement work in PDE. THanks. Looks I like forgot to merge this one, sorry Olivier. We need another committer reviewer for RC3, I asked Simon. Yes :) No problem... there are so many bugs to follow :) ! Forgot to merge the change. How critical is this change for Mars? I fear that we are introducing new bugs in the editor with this change? The part descriptors are displayed with their icons. Views, windows too... The gray icon is computed depending on the dynamic icon you set... Your fear comes from the number of lines changed due to a code reformat... Open the model spy on your current IDE and compare with the previous version... and make your opinion... (In reply to Olivier Prouvost from comment #11) > The part descriptors are displayed with their icons. Views, windows too... > The gray icon is computed depending on the dynamic icon you set... > Your fear comes from the number of lines changed due to a code reformat... > Open the model spy on your current IDE and compare with the previous > version... and make your opinion... The fear also comes from Dirks testing of the last patch and the reported exceptions by him. ;-) I test this again and let you know. Yes I understand ! As it has not been merged early it could not be tested a lot... But we have still RC3 and RC4 if there is any problem. The refresh in the tree (if you change the Icon URI in the editor) must be done manually by double clicking on visible checkbox or by changing the label for instance ... I could not find it for the moment... This is a data binding EMF issue on this particular field... Really in 4.6 ?? (In reply to Olivier Prouvost from comment #14) > Really in 4.6 ?? It's too late for Mars. If this is important and proves to work in Neon, we can still consider 4.5.1. (In reply to Dani Megert from comment #15) > It's too late for Mars. If this is important and proves to work in Neon, we > can still consider 4.5.1. Lets try 4.5.1. This requires that this is merged in master for Neon and if it works fine, we can cherry pick it onto the maintenance branch. Ok. I will retest it for 4.5.1. That would be great to have if for this release... Must check for instance this kind of url : platform:/plugin/org.eclipse.ui.ide.application/$nl$/icons/full/eview16/resource_persp.png Gerrit change https://git.eclipse.org/r/46354 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=0772fbb9bd0838f083e04a095bf3362136dd5278 Dani, once this has been intensively tested (I will use this change in my next RCP training in two weeks), it would be great to downport it to 4.5.1. I forgot the process for this, can you shared you link to the process description? https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_5.php seem not to cover it. (In reply to Lars Vogel from comment #19) > Dani, once this has been intensively tested (I will use this change in my > next RCP training in two weeks), it would be great to downport it to 4.5.1. To approve I need someone stating here that the patch does not change or remove any API and list all API additions (if any). > I forgot the process for this, can you shared you link to the process > description? > https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_5.php seem > not to cover it. We have similar freeze plans for the maintenance releases. It's on my list to post it. Stay tuned! Additionnel API, only in AbstractComponentEditor : * public Image getImageFromIconURI(MUILabel element) returns the Image if there is an IconURI value. It deals with platform:/plugin, platform:/resource and platform:/.../ $nls$ * public Image getImage(Object element, String key) returns the Image for an element with a default key if there is no IconURI. Compute the grey icon too. * public Image getImage(Object element) abstract must be implemented in subclasses with a call to getImage(element, key) * private ImageDescriptor getImageDescriptorFromUri(String uri) computes the ImageDescriptor from a string URI * private Image getImage(String key, boolean grey) returns the Image for a key (when no IconURI) and compute the grey variation. * private boolean shouldBeGrey(Object element) returns true if this element should display a grey image (not rendered...) I guess it is all. (In reply to Olivier Prouvost from comment #21) > Additionnel API, only in AbstractComponentEditor : AFACS org.eclipse.e4.tools exports no API, everything is marked as x-internal (In reply to Dani Megert from comment #20) > To approve I need someone stating here that the patch does not change or > remove any API and list all API additions (if any). All is still x-internal in org.eclipse.e4.tools New Gerrit change created: https://git.eclipse.org/r/53919 Gerrit change https://git.eclipse.org/r/53919 was merged to [R4_5_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=e59968c4739b901833550e1f4fe71b33b64fa29f (In reply to Eclipse Genie from comment #25) > Gerrit change https://git.eclipse.org/r/53919 was merged to > [R4_5_maintenance]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/ > ?id=e59968c4739b901833550e1f4fe71b33b64fa29f Update the MANIFEST and pom version with Gerrit change https://git.eclipse.org/r/53920 was merged to [R4_5_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=a2c8702e9dc7ea82f908b10afce58a9f6d00dd9e *** Bug 466540 has been marked as a duplicate of this bug. *** |