Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 465117

Summary:	[metrics] provide more targeted metrics to know what preferences are changed
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public, grant_gayed
Version:	8.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Michael Rennie

2015-04-21 10:40:14 EDT

We should expand on the metrics for logging preference changed events to also log:

1. what preference was changed (exactly)
2. what the preference was changed to
3. (maybe) what the preference was changed from

We should do this for JavaScript and HTML / CSS. I think this will help us choose what defaults should be for preferences.

Comment 1 Grant Gayed

2015-04-21 12:05:59 EDT

I think #1 and #2 are covered by the current metrics logging (?).  Or are you saying _where_ a setting is changed (eg.- the editor's local menu vs. the Settings page)?

Examples of what we're currently logging, format is "settingId...newValue":

/editor/settings/editorSettings/autoSave...true
/editor/settings/editorSettings/autoSave...false
/editor/settings/editorSettings/autoSaveTimeoutLocalVisible...true
/editor/settings/editorSettings/autoSaveTimeoutLocalVisible...false
/cm/configurations/csslint.config/validate_rules_count...0
/cm/configurations/csslint.config/validate_rules_count...2
/git/config/userInfo/GitSelectAll...true
/git/config/userInfo/GitSelectAll...false

Comment 2 Michael Rennie

2015-04-22 09:50:50 EDT

(In reply to Grant Gayed from comment #1)

> Examples of what we're currently logging, format is "settingId...newValue":
> 
> /editor/settings/editorSettings/autoSave...true
> /editor/settings/editorSettings/autoSave...false
> /editor/settings/editorSettings/autoSaveTimeoutLocalVisible...true
> /editor/settings/editorSettings/autoSaveTimeoutLocalVisible...false
> /cm/configurations/csslint.config/validate_rules_count...0
> /cm/configurations/csslint.config/validate_rules_count...2
> /git/config/userInfo/GitSelectAll...true
> /git/config/userInfo/GitSelectAll...false

That's exactly what I was wanting. I will play around setting up some views on our tooling dashboard and see what I can see.

Comment 3 Michael Rennie

2015-04-22 11:20:37 EDT

There is enough data there already. Closing.