Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 464738

Summary: Git credentials are not stored when using private key file
Product: [ECD] Orion Reporter: Curtis Windatt <curtis.windatt.public>
Component: GitAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: maciej.bendkowski
Version: 8.0   
Target Milestone: 9.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Fix to include username in storage none

Description Curtis Windatt CLA 2015-04-15 16:22:46 EDT 
Since I switched over to an ssh url and using a private ssh key file to authenticate, Orion has not been saving my credentials.  I debugged through the process and see that the passkey is being stored correctly, but the username is not included.  Without a username the authentication is rejected and I'm forced to re-enter using the git credentials dialog.

I will attach a patch that fixes the issue for review.
Comment 1 Curtis Windatt CLA 2015-04-15 16:24:34 EDT 
Created attachment 252435 [details]
Fix to include username in storage

Adds gitSshUsername to the object passed to storage.  Also fixes the indentation.
Comment 2 Curtis Windatt CLA 2015-04-15 16:26:04 EDT 
See any issues with this change Maciej?
Comment 3 Maciej Bendkowski CLA 2015-04-16 13:17:10 EDT 
(In reply to Curtis Windatt from comment #2)
> See any issues with this change Maciej?

The change seems fine to me. I double checked all references to the git preference storage to make sure that this was the only place missing the ssh name. Your change should resolve the issue.