Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 464730

Summary:	default themes can be overridden by theme importer
Product:	[ECD] Orion	Reporter:	Grant Gayed <grant_gayed>
Component:	Client	Assignee:	Umar Bolatov <ubolatov>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ubolatov
Version:	8.0
Target Milestone:	9.0
Hardware:	PC
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/45956 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=852de03ba9cdc2509fc03c1c56215aae7ae2b706
Whiteboard:

Description Grant Gayed

2015-04-15 13:46:38 EDT

- import a Brackets theme
- when it asks for the theme's name enter "Prospecto"
  -> this will replace the default Prospecto theme with the imported one, which is not allowed

Comment 1 Umar Bolatov

2015-04-15 13:58:01 EDT

(In reply to Grant Gayed from comment #0)
> - import a Brackets theme
> - when it asks for the theme's name enter "Prospecto"
>   -> this will replace the default Prospecto theme with the imported one,
> which is not allowed

This would also mean that any other theme that is named "Prospecto" or "Darker" (if they exist) could override any of the default themes.

Comment 2 Eclipse Genie

2015-04-16 13:55:07 EDT

New Gerrit change created: https://git.eclipse.org/r/45956

Comment 3 Eclipse Genie

2015-04-16 15:35:18 EDT

Gerrit change https://git.eclipse.org/r/45956 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=852de03ba9cdc2509fc03c1c56215aae7ae2b706

Comment 4 Grant Gayed

2015-04-16 15:59:34 EDT

Comment 2 fix is pushed, along with follow-up commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=57c7d2fb3672625b4203c27ab2302181c6024bd8 .


Closing report as FIXED.