| Summary: | [CSS] Improve CSS syntax highlighting | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Umar Bolatov <ubolatov> |
| Component: | Client | Assignee: | Project Inbox <orion.client-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | curtis.windatt.public |
| Version: | 8.0 | ||
| Target Milestone: | 9.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| See Also: | https://git.eclipse.org/r/45991 | ||
| Whiteboard: | |||
|
Description
Umar Bolatov
New Gerrit change created: https://git.eclipse.org/r/45991 Issues with this proposed change: 1) It is far out of date with master so rebasing results in a lot of conflicts 2) It includes a number of changes to colours outside of the css selectors 3) Nothing is included for the new Ceol theme. 4) id should be capitalized ID 5) Seems odd to have a /* bad practice */ code snippet in the example 6) The theme preview wasn't working for me, but that may be because of bad conflict resolution. Also caught Bug 473241. I'm closing this as WONTFIX as I don't see this as worth pursuing. Umar, if you have time to work on it, please reopen and I will review new changes. |