Bugzilla – Full Text Bug Listing
| Summary: | [Theme Import] Add Markdown styling for imported themes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Umar Bolatov <ubolatov> | ||||
| Component: | Client | Assignee: | Umar Bolatov <ubolatov> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | curtis.windatt.public, grant_gayed | ||||
| Version: | 8.0 | ||||||
| Target Milestone: | 9.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| See Also: |
https://git.eclipse.org/r/45594 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2b7422b3b807b5704ff835c586aea176ae210268 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
If a theme being imported was detected to be dark then using "darker" as the base theme instead of "prospecto" would fix a case like this (assuming the underlying issue is that the imported theme does not specify any stylings for markup* regions, so they're being left as those that come from the default theme). (In reply to Grant Gayed from comment #1) > If a theme being imported was detected to be dark then using "darker" as the > base theme instead of "prospecto" would fix a case like this (assuming the > underlying issue is that the imported theme does not specify any stylings > for markup* regions, so they're being left as those that come from the > default theme). True, that would work. However, oftentimes, there is no way to tell if a theme is dark (we could check for background colors and detect them this way, I guess). Also, many themes actually specify Markdown-specific styles, so I thought we might as well use those. New Gerrit change created: https://git.eclipse.org/r/45594 Gerrit change https://git.eclipse.org/r/45594 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2b7422b3b807b5704ff835c586aea176ae210268 Commits: - http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2b7422b3b807b5704ff835c586aea176ae210268 - http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=dde141daba13b443b6f19486a76d1e802f6e6d48 New Bugs: - Bug 464729 - import of Sublime or Brackets theme is incomplete if background colour is not first attribute - Bug 464730 - default themes can be overridden by theme importer Closing report as FIXED. |
Created attachment 252263 [details] Markdown presentation in an imported dark theme Currently, imported themes do not style Markdown. This is a problem for dark themes. Markdown headings become hard to read. See attached screenshot.