Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 464269

Summary:

Allow specifier to choose the selected elements after a tool execution

Product:

[Modeling] Sirius

Reporter:

Laurent Redor <laurent.redor>

Component:

Diagram

Assignee:

Laurent Fasani <laurent.fasani>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

florian.barbin, laurent.fasani, maxime.porhel, pierre-charles.david, steve.monnier

Version:

0.9

Keywords:

triaged

Target Milestone:

3.1.0

Hardware:

All

OS:

All

See Also:

Whiteboard:

Bug Depends on:

Bug Blocks:

428545

Attachments:

Description	Flags
464269Project.zip	none

Description Laurent Redor

2015-04-09 05:46:03 EDT

Currently, after a tool execution, all new graphical elements are selected (in the creation order). The last created graphical element is the primary selection.

This behavior is not always the expected one. For example, just after a creation, the direct edit tool is available on the primary selection (the last created graphical element). If the direct edit tool must operate on the first created graphical element, the user must select the diagram and then select again the first created graphical element to direct edit.

The goal of this feature is to propose a solution to handle this problematic: allow the specifier to choose the selected elements after a tool execution.

Comment 1 Laurent Redor

2015-04-10 11:59:47 EDT

Created attachment 252301 [details]
464269Project.zip

Problematic scenarios: These scenarios use the project 464269 (in 464269Project.zip) and reveal some selection problems.

Move of a border node
---------------------
* Import the project 464269 and open "newDiagram"
* Ensure you are in manual refresh mode (preference Sirius/Automatic Refresh equals to false).
* Use the tool "InOutEdge" between A and B
--> A green out port is created on A, a blue in port is created on B and an edge is created between them. All of them are selected.
* Without modification the selection, move the blue port on B.
--> KO the green port is drag and drop on B. In this case, the specifier wants that only the edge is selected.

Direct edit of a created node
-----------------------------
* Import the project 464269 and open "newDiagram"
* Ensure you are in manual refresh mode (preference Sirius/Automatic Refresh equals to false).
* Use the tool "Create sub class with Views Creation" on B
--> A subClass is created and also the hierarchy link bewteen the subClass and B.
--> KO the direct edit is not possible on the subClass. You should first select the diagram and the select again the subClass to direct edit it. In this case, the specifier wants that only the subClass is selected.
The other tool "Create sub class with forceRefresh" does the same modification but the view is created by the refresh and not by the tool.

Partial selection of the created elements
-----------------------------------------
* Import the project 464269 and open "newDiagram"
* Ensure you are in manual refresh mode (preference Sirius/Automatic Refresh equals to false).
* Use the tool "Composite pattern With Views Creation" on diagram
--> KO the specifier wants that only the "Component" class is selected after the execution of the tool, to allow to direct edit it.

Comment 2 Eclipse Genie

2015-04-21 09:57:50 EDT

New Gerrit change created: https://git.eclipse.org/r/46181

Comment 3 Eclipse Genie

2015-04-22 03:02:50 EDT

Gerrit change https://git.eclipse.org/r/46181 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d8ac477147d385f28ba23ec47a0965c180401b8e

Comment 4 Laurent Redor

2015-04-22 03:09:01 EDT

A spec is available here [1]. Do not hesitate to give feedback on it.

[1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/plain/plugins/org.eclipse.sirius.doc/specs/proposal/464269_selectElementsAfterToolExecution/464269.html?id=d8ac477147d385f28ba23ec47a0965c180401b8e

Comment 5 Eclipse Genie

2015-04-27 08:17:30 EDT

New Gerrit change created: https://git.eclipse.org/r/46550

Comment 6 Eclipse Genie

2015-04-27 08:20:24 EDT

Gerrit change https://git.eclipse.org/r/46550 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a5556b5ede79c40f563843b54925e42baeb8313c

Comment 7 Eclipse Genie

2015-06-22 12:09:41 EDT

WARNING: this patchset contains 3640 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire

Comment 8 Eclipse Genie

2015-06-30 10:47:05 EDT

New Gerrit change created: https://git.eclipse.org/r/51109

Comment 9 Eclipse Genie

2015-08-04 09:02:58 EDT

Gerrit change https://git.eclipse.org/r/50612 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a0f13eb71060917cf8d340b793212ab1245ce461

Comment 10 Eclipse Genie

2015-08-04 09:05:12 EDT

Gerrit change https://git.eclipse.org/r/50613 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5be107c34a8ba2e72d27203b92be004d748f28f5

Comment 11 Laurent Fasani

2015-08-04 09:16:05 EDT

fixed

Comment 12 Eclipse Genie

2015-08-05 03:14:34 EDT

New Gerrit change created: https://git.eclipse.org/r/53200

Comment 13 Eclipse Genie

2015-08-05 03:42:22 EDT

Gerrit change https://git.eclipse.org/r/53200 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3092d13542f7a067253168b243ccde11d7fffb18

Comment 14 Eclipse Genie

2015-08-05 05:06:40 EDT

New Gerrit change created: https://git.eclipse.org/r/53208

Comment 15 Eclipse Genie

2015-08-05 06:07:41 EDT

New Gerrit change created: https://git.eclipse.org/r/53211

Comment 16 Eclipse Genie

2015-08-06 02:54:55 EDT

Gerrit change https://git.eclipse.org/r/53211 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=73f6363dd011a81e63d989de3e35f0ec2af489db

Comment 17 Florian Barbin

2015-09-23 08:54:37 EDT

Verified with 3.1.0.201509211006

Comment 18 Pierre-Charles David

2015-10-16 09:11:00 EDT

Available in Sirius 3.1.0.