Bugzilla – Full Text Bug Listing
|
Description
Szymon Ptaszkiewicz
New Gerrit change created: https://git.eclipse.org/r/45476 New Gerrit change created: https://git.eclipse.org/r/45478 New Gerrit change created: https://git.eclipse.org/r/45479 There are also some OSGi classes in the org.eclipse.equinox.preferences project but they do not produce any warnings so I didn't change it for the time being. In the long term, it may be a good idea to move them to a separate source folder as well. Gerrit change https://git.eclipse.org/r/45479 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=71f623df7e43d2f54864d17c692475dcae3ba21d Gerrit change https://git.eclipse.org/r/45478 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=514d2bc398399f0d61cbbc577aa0bec83591c7a0 Gerrit change https://git.eclipse.org/r/45476 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=d5ecf18441b571691f7d9b6f22e4019e29962742 Thanks again! When you touch source folders or add/remove packages or dependencies, you also have to update Javadoc generation: https://wiki.eclipse.org/index.php/How_to_add_things_to_the_Eclipse_doc Problems in N-build: http://download.eclipse.org/eclipse/downloads/drops4/N20150409-2000/compilelogs/platform.doc.isv.javadoc.txt (In reply to Markus Keller from comment #9) > When you touch source folders or add/remove packages or dependencies, you > also have to update Javadoc generation: > https://wiki.eclipse.org/index.php/How_to_add_things_to_the_Eclipse_doc > > Problems in N-build: > http://download.eclipse.org/eclipse/downloads/drops4/N20150409-2000/ > compilelogs/platform.doc.isv.javadoc.txt Szymon, will you handle that? (In reply to Thomas Watson from comment #10) > (In reply to Markus Keller from comment #9) > > When you touch source folders or add/remove packages or dependencies, you > > also have to update Javadoc generation: > > https://wiki.eclipse.org/index.php/How_to_add_things_to_the_Eclipse_doc > > > > Problems in N-build: > > http://download.eclipse.org/eclipse/downloads/drops4/N20150409-2000/ > > compilelogs/platform.doc.isv.javadoc.txt > > Szymon, will you handle that? Yes, I will fix it. New Gerrit change created: https://git.eclipse.org/r/45668 (In reply to Eclipse Genie from comment #12) > New Gerrit change created: https://git.eclipse.org/r/45668 I pushed a change that adds org.eclipse.equinox.app/osgi as a new source folder. I didn't add other source folders that were created because they were not mentioned in the log as problematic. Should they be added as well even if javadoc log does not complain about them? (In reply to Szymon Ptaszkiewicz from comment #13) > (In reply to Eclipse Genie from comment #12) > > New Gerrit change created: https://git.eclipse.org/r/45668 > > I pushed a change that adds org.eclipse.equinox.app/osgi as a new source > folder. I didn't add other source folders that were created because they > were not mentioned in the log as problematic. Should they be added as well > even if javadoc log does not complain about them? I had a chat with Tom about that and we agreed that we should add only source folders for those projects that had already its source folder mentioned earlier which means only the entry for org.eclipse.equinox.app/osgi was missing. Gerrit change https://git.eclipse.org/r/45668 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=4a193a7354c18fcb37258ba43dd7672eac9a7a70 Marking fixed. I will keep an eye on today's N-build to verify javadoc is happy. (In reply to Szymon Ptaszkiewicz from comment #14) > I had a chat with Tom about that and we agreed that we should add only > source folders for those projects that had already its source folder > mentioned earlier which means only the entry for > org.eclipse.equinox.app/osgi was missing. I agree that the other source folders are probably not necessary today, but I think they should be added anyway. Just to be complete and to avoid surprises as soon as an Equinox API type refers to an OSGi type. Furthermore, the Javadoc for org.eclipse.equinox.app.IApplicationContext#APPLICATION_ARGS contains {@link ApplicationDescriptor#launch(Map)}, but this link is not resolved in the generated doc: http://help.eclipse.org/luna/topic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/equinox/app/IApplicationContext.html#APPLICATION_ARGS I've added the missing reference to R5 compendium and added links to compendium/enterprise in the TOC: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=4a193a7354c18fcb37258ba43dd7672eac9a7a70 |