Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 464153

Summary:	External web browser parameters are not updated after change on preference page
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Markus Keller <markus.kell.r>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	bsd, markus.kell.r
Version:	4.5
Target Milestone:	4.6 M6
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	238452, 247731
Bug Blocks:

Description Markus Keller

2015-04-08 08:48:26 EDT

External web browser parameters are not updated after a change on the preference page. To test new parameters, a user would always have to restart Eclipse.

Steps:
- Preferences > Web Browser: Select Firefox as external web browser and set parameters to "www.google.com"
- double-click a *.html file
=> new browser windows opens with two tabs (Google, the opened file)

- now open prefs again and change the parameter to www.bing.com
- double-click a *.html file
=> new browser windows opens with two tabs (Google, the opened file)
=> the changed parameter is not used until after a restart

Comment 1 Brian de Alwis

2016-02-05 13:56:01 EST

I can't reproduce this.  It may have been fixed by bug 486288, though I'm not sure how.  Marking as WORKSFORME.

Comment 2 Markus Keller

2016-02-08 08:34:40 EST

The steps still reproduce the problem.

It's hard to find the actual issue in the obfuscated code, so I basically had to step through. The problem is not in the preference page but in org.eclipse.ui.internal.browser.browsers.MozillaFactory, which caches outdated state. A similar issue had already been hacked around in bug 247731 and soon after broken again in bug 238452.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6e6a9cc2133581331fc50ab64b66748807ba78d5