Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 463879

Summary:	Regenerate application model with new EMF version to fix JavaDoc errors
Product:	[Eclipse Project] Platform	Reporter:	Thomas Schindl <tom.schindl>
Component:	UI	Assignee:	Thomas Schindl <tom.schindl>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel
Version:	4.5
Target Milestone:	4.5 M7
Hardware:	PC
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/45214 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f5d7cfdcbcf3c73a557b6fc8094ef180c3fbc993 https://git.eclipse.org/r/45383 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5963a8b21885289233cbc28843ea11af2df5719c
Whiteboard:
Bug Depends on:
Bug Blocks:	460826

Description Thomas Schindl

2015-04-03 05:25:31 EDT

EMF fixed some JavaDoc errors so regenerating the model fixes them. This also allows to see what changes are really done when regenerating code.

Comment 1 Eclipse Genie

2015-04-03 05:28:27 EDT

New Gerrit change created: https://git.eclipse.org/r/45214

Comment 2 Thomas Schindl

2015-04-03 05:46:58 EDT

How do we deal today with the error generated from the EMF-Generated code?

Comment 3 Eclipse Genie

2015-04-03 06:09:08 EDT

Gerrit change https://git.eclipse.org/r/45214 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f5d7cfdcbcf3c73a557b6fc8094ef180c3fbc993

Comment 4 Thomas Schindl

2015-04-03 06:10:37 EDT

I merged the JavaDoc changes - if we can make modifications to the build to not suppress warnings in emf we could do that in another bugzilla

Comment 5 Dani Megert

2015-04-07 09:58:11 EDT

Tom, this change now re-exports 
 org.eclipse.emf.ecore;bundle-version="2.9.0";visibility:=reexport,
and requires itself:
 org.eclipse.e4.ui.model.workbench;visibility:=reexport,

This looks wrong. If not, you have to ask for PMC approval since this is an API change after the freeze, see
http://download.eclipse.org/eclipse/downloads/drops4/N20150406-2000/apitools/freeze_report.html

Comment 6 Eclipse Genie

2015-04-07 10:30:18 EDT

New Gerrit change created: https://git.eclipse.org/r/45383

Comment 7 Eclipse Genie

2015-04-07 10:31:14 EDT

Gerrit change https://git.eclipse.org/r/45383 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5963a8b21885289233cbc28843ea11af2df5719c

Comment 8 Thomas Schindl

2015-04-07 10:32:24 EDT

Sorry this was not intentional - looks like I've not spotted these modifications. I think the https://git.eclipse.org/r/45383 fixed this.

Comment 9 Thomas Schindl

2015-04-07 10:32:36 EDT

Comment 10 Thomas Schindl

2015-04-09 03:40:43 EDT

I filed bug 464245 for the invalid MANIFEST.MF

Comment 11 Lars Vogel

2015-04-28 06:32:07 EDT