Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 463821

Summary:	Eclipse 4 RCP template always creates an Activator
Product:	[Eclipse Project] PDE	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Olivier Prouvost <olivier.prouvost>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, Vikas.Chandra
Version:	4.5
Target Milestone:	4.5 M7
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/45187 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=4029ef0ec0a5a9fd5dafbfea7534336d9a13c695
Whiteboard:
Bug Depends on:	441331
Bug Blocks:	463822

Description Lars Vogel

2015-04-02 11:03:33 EDT

The template introduce with Bug always creates an Activator. Please consider the flag from the wizard page.

Comment 1 Lars Vogel

2015-04-02 11:04:25 EDT

Bug 441331.441331

Comment 2 Eclipse Genie

2015-04-02 18:38:15 EDT

New Gerrit change created: https://git.eclipse.org/r/45187

Comment 3 Olivier Prouvost

2015-04-02 18:42:21 EDT

When activator must be generated the value in previous page (IFieldData) is now taken into account.

Comment 4 Lars Vogel

2015-04-03 04:55:28 EDT

Needs to be merged.

Comment 5 Lars Vogel

2015-04-07 06:11:16 EDT

Vikas, can this be reviewed soon? At the moment the generated e4 RCP project has syntax errors.

Comment 6 Lars Vogel

2015-04-07 06:12:15 EDT

*** Bug 463822 has been marked as a duplicate of this bug. ***

Comment 7 Lars Vogel

2015-04-07 06:12:50 EDT

This fix should also fix the syntax error in the generated project reported by Bug 463822.

Comment 8 Eclipse Genie

2015-04-10 06:53:44 EDT

Gerrit change https://git.eclipse.org/r/45187 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=4029ef0ec0a5a9fd5dafbfea7534336d9a13c695

Comment 9 Vikas Chandra

2015-04-10 06:55:18 EDT

See previous commit

Comment 10 Lars Vogel

2015-04-10 08:08:19 EDT

Thanks Vikas for the merge and Olivier for the patch

Comment 11 Vikas Chandra

2015-04-27 05:16:08 EDT

Lars, can you please verify this one.

Comment 12 Lars Vogel

2015-04-28 05:05:34 EDT

Validated in 4.5.0.N20150425-1500 that the activator flag is now considered during project creation.

(In reply to Lars Vogel from comment #7)
> This fix should also fix the syntax error in the generated project reported
> by Bug 463822.

Unfortunately this is not the case. Reopened Bug 463822.