Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 463748

Summary:	Require core.di.annotations instead of core.di whenever possible
Product:	[Eclipse Project] Platform	Reporter:	Thomas Schindl <tom.schindl>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel
Version:	4.5
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:	stalebug
Bug Depends on:	451381
Bug Blocks:

Description Thomas Schindl

2015-04-02 03:44:50 EDT

We have not splitted out core.di.annotations and should make use of it where ever possible

Comment 1 Thomas Schindl

2015-04-02 03:55:39 EDT

I looked at all bundles in platform & platform ui and unfortunately they are all structured in a way that they require core.di most of them also make use of ContextInjectionFactory who shows InjectionException in its API.

We could switch to core.di.annotations if:
a) we remove the InjectionException from the API in ContextInjectionFactory - its 
   anways only a RuntimeException so this is a no breaking change - I'm not what 
   sense it makes to show a RuntimeException in the throws clause (the only 
   purpose is documentation?)
b) modify build.properties to hold "additional.bundles = org.eclipse.e4.core.di"

I think the only viable way would be a)

Comment 2 Lars Vogel

2015-04-02 03:58:37 EDT

(In reply to Thomas Schindl from comment #0)
> We have not splitted out core.di.annotations and should make use of it where
> ever possible

I think the "not" is incorrect here and potentially confusing. I assume you mean:

We have NOW splitted out core.di.annotations and should make use of it where
ever possible

Comment 3 Thomas Schindl

2015-04-02 04:05:53 EDT

I filed bug 463756 - I'm untargeting this for M7

Comment 4 Lars Vogel

2016-04-25 15:16:32 EDT

Mass move to 4.7.

Comment 5 Eclipse Genie

2020-02-01 16:11:41 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.