Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 463747

Summary:	Adjust org.eclipse.e4.rcp to add "org.eclipse.e4.core.di.annotations"
Product:	[Eclipse Project] Platform	Reporter:	Thomas Schindl <tom.schindl>
Component:	UI	Assignee:	Thomas Schindl <tom.schindl>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel
Version:	4.5
Target Milestone:	4.5 M7
Hardware:	PC
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/45103 https://git.eclipse.org/r/45168 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=579c493f3bcdf1aadf96273092ef9893e69eb7aa
Whiteboard:
Bug Depends on:	451381
Bug Blocks:

Description Thomas Schindl

2015-04-02 03:39:43 EDT

With the change in bug 451381 we need to add a new bundle to the feature

Comment 1 Eclipse Genie

2015-04-02 03:41:36 EDT

New Gerrit change created: https://git.eclipse.org/r/45103

Comment 2 Thomas Schindl

2015-04-02 03:42:51 EDT

I'm not sure but i think I also need to update the feature version to 1.4.0?

Comment 3 Lars Vogel

2015-04-02 03:56:06 EDT

(In reply to Thomas Schindl from comment #2)
> I'm not sure but i think I also need to update the feature version to 1.4.0?

What do the Releng tools tell you? See Bug 443353 which added this check.

Comment 4 Lars Vogel

2015-04-02 03:56:41 EDT

(In reply to Lars Vogel from comment #3)
> What do the Releng tools tell you? See Bug 443353 which added this check.
Sorry Bug reference is wrong.

Comment 5 Dani Megert

2015-04-02 09:36:50 EDT

(In reply to Thomas Schindl from comment #2)
> I'm not sure but i think I also need to update the feature version to 1.4.0?

Correct.

Comment 6 Thomas Schindl

2015-04-02 09:39:52 EDT

ok i pushed a new changeset to orbit who update the version to 1.4.0 - naturally the build fails because there's no core.runtime build yet available. Can I push the change or do we want to wait for a new core.runtime build until i do so?

Comment 7 Dani Megert

2015-04-02 09:44:52 EDT

(In reply to Thomas Schindl from comment #6)
> ok i pushed a new changeset to orbit who update the version to 1.4.0 -
> naturally the build fails because there's no core.runtime build yet
> available. Can I push the change 

Yes.

Comment 8 Eclipse Genie

2015-04-02 13:55:51 EDT

New Gerrit change created: https://git.eclipse.org/r/45168

Comment 9 Eclipse Genie

2015-04-02 13:58:03 EDT

Gerrit change https://git.eclipse.org/r/45168 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=579c493f3bcdf1aadf96273092ef9893e69eb7aa

Comment 10 Thomas Schindl

2015-04-02 13:58:18 EDT