Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 463507

Summary: Going from landing -> login page clears the redirect
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Umar Bolatov <ubolatov>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse, ubolatov
Version: 8.0   
Target Milestone: 9.0   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/45037
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ab8c306579e2ee448d7590ec32dddcdc8c0572da
Whiteboard:

Description Mark Macdonald CLA 2015-03-30 13:42:23 EDT
Recent changes to the landing/login pages have made one scenario regress:

1. In browser tab A, open the file navigator at orion.eclipse.org.
2. In browser tab B, log out.
3. In tab A, right-click (or Ctrl+click) a file in the navigator and open it in a new tab. You will get bounced to the landing page.
4. Click "Sign In", which takes you to the login form. Enter your credentials and continue.
5. I expected to end up at the file that I originally clicked on in step 3, but instead I land at the top of the navigator.

If you repeat these steps on Orionhub.org (which is running a build that predates the login/landing changes) you get the expected result.

The problem begins in Step 4. When you go from landing.html to LoginWindow.html, the ?redirect query param is discarded. It should be kept, since it records the filename that you wanted to edit.
Comment 1 Eclipse Genie CLA 2015-04-01 12:24:59 EDT
New Gerrit change created: https://git.eclipse.org/r/45037
Comment 3 Mark Macdonald CLA 2015-04-01 14:00:10 EDT
Fixed by previous change via Gerrit