Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 463456

Summary: Add support for editing long expressions in the VSM editor
Product: [Modeling] Sirius Reporter: Benjamin Grouhan <benjamin.grouhan>
Component: CoreAssignee: Benjamin Grouhan <benjamin.grouhan>
Status: CLOSED FIXED QA Contact: Belqassim Djafer <belqassim.djafer>
Severity: normal    
Priority: P3 CC: cedric.brun, laurent.redor, pierre-charles.david, steve.monnier
Version: unspecifiedKeywords: triaged
Target Milestone: 3.0.0M7   
Hardware: PC   
OS: All   
See Also: https://git.eclipse.org/r/45248
https://git.eclipse.org/r/45483
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=df4adcc82a9fdca8eb13e1b4b19011455454430c
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0a64eb1bc2399e8d72a6b2be8fb3f6acb794589c
https://git.eclipse.org/r/45552
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f56516d0f0627301667522ba493d51a745ba9fa4
https://git.eclipse.org/r/46576
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0c73dd0f011c0d42bffe0769b215f102a0e203b3
Whiteboard: needtest

Description Benjamin Grouhan CLA 2015-03-30 09:19:55 EDT
Currently when a specifier enters an interpreted expression in the VSM editor, we only provide a single-line text field. Even for Acceleo 2, it is sometimes too small to be readable, and Acceleo 3 is more verbose than Acceleo 2. We need to provide support for entering long (including multi-line) expressions from within the VSM editor.
One possibility is to add a button labelled Edit... at the right of every interpreted expression text field. When clicked, it would open a simple dialog box with a multi-line text area initialized with the current value of the expression, so that the specifier can edit it more confortably. The dialog box could provide a combo where the user can select the language to use (Acceleo 2, Acceleo 3, OCL, plain text...), and some languages/interpreters could provide a richer editor (for example with syntax coloring and completion). Acceleo 3 could reuse the widget used to enter expressions in the Requestor view.
Comment 1 Eclipse Genie CLA 2015-04-03 12:17:20 EDT
New Gerrit change created: https://git.eclipse.org/r/45248
Comment 2 Eclipse Genie CLA 2015-04-08 12:14:58 EDT
New Gerrit change created: https://git.eclipse.org/r/45483

WARNING: this patchset contains 2796 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 5 Eclipse Genie CLA 2015-04-09 09:30:56 EDT
New Gerrit change created: https://git.eclipse.org/r/45552
Comment 8 Laurent Redor CLA 2015-04-21 08:11:29 EDT
There is a regression since this issue: all *PropertySection classes have lost the "implements ContentProposalClient".
Comment 9 Pierre-Charles David CLA 2015-04-24 08:31:17 EDT
*** Bug 465379 has been marked as a duplicate of this bug. ***
Comment 10 Eclipse Genie CLA 2015-04-27 12:12:35 EDT
New Gerrit change created: https://git.eclipse.org/r/46576
Comment 12 Benjamin Grouhan CLA 2015-04-28 04:07:53 EDT
Regression fixed.
Comment 13 Belqassim Djafer CLA 2015-05-21 11:20:55 EDT
Verified with Sirius 3.0.0 RC1
Comment 14 Pierre-Charles David CLA 2015-06-24 11:13:40 EDT
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.