Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 463223

Summary:	Write Javadoc for MModelFragment.merge
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Steven Spungin <steven>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel, steven
Version:	4.5
Target Milestone:	4.5 M7
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/44732 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7aa280fdfbe32d109f23e480edb9052e83c8d88f https://git.eclipse.org/r/44841 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d52420f976cb946b2e109e8d9dc977e00f6ef657
Whiteboard:
Bug Depends on:
Bug Blocks:	437958

Description Lars Vogel

2015-03-26 12:07:19 EDT

Comment 1 Lars Vogel

2015-03-26 12:08:40 EDT

Steven, for Dani to accept the change in Bug 437958, we need to document the merge method via Javadoc. Can you provide a patch for that?

Comment 2 Eclipse Genie

2015-03-27 07:32:40 EDT

New Gerrit change created: https://git.eclipse.org/r/44732

Comment 3 Eclipse Genie

2015-03-27 09:28:03 EDT

Gerrit change https://git.eclipse.org/r/44732 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7aa280fdfbe32d109f23e480edb9052e83c8d88f

Comment 4 Lars Vogel

2015-03-27 09:28:42 EDT

Thanks Steven.

Comment 5 Dani Megert

2015-03-30 09:04:55 EDT

I assume

Merges an MModelFragment into an MApplication.

should be:

Merges this MModelFragment into an MApplication.

right?

Comment 6 Steven Spungin

2015-03-30 09:06:30 EDT

That is correct.  Should I change that now, or wait?

Comment 7 Eclipse Genie

2015-03-30 09:08:17 EDT

New Gerrit change created: https://git.eclipse.org/r/44841

Comment 8 Eclipse Genie

2015-03-30 09:10:51 EDT

Gerrit change https://git.eclipse.org/r/44841 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d52420f976cb946b2e109e8d9dc977e00f6ef657

Comment 9 Lars Vogel

2015-03-30 09:11:18 EDT

(In reply to Steven Spungin from comment #6)
> That is correct.  Should I change that now, or wait?

Fixed. 

Thanks Dani for the feedback.