Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 463125

Summary: Error-Check for application without windows is done before fragments have been merged
Product: [Eclipse Project] Platform Reporter: Thomas Schindl <tom.schindl>
Component: UIAssignee: Thomas Schindl <tom.schindl>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, Lars.Vogel, markus.kell.r
Version: 4.5   
Target Milestone: 4.5 M7   
Hardware: PC   
OS: Mac OS X   
See Also: https://git.eclipse.org/r/44625
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ece1746f9356f6297cb2021284bc74ab2d2d3e7a
Whiteboard:

Description Thomas Schindl CLA 2015-03-25 14:22:33 EDT 
In bug 416673 a change was merged who added a check for if there's an application without a window but the check is done too early because it it total legal to have a base Application.e4xmi without a window and contribute that from an other fragment!
Comment 1 Eclipse Genie CLA 2015-03-25 14:26:50 EDT 
New Gerrit change created: https://git.eclipse.org/r/44625
Comment 3 Thomas Schindl CLA 2015-03-26 03:50:58 EDT 
.
Comment 4 Lars Vogel CLA 2015-03-26 04:28:13 EDT 
Never noticed that problem. Thanks Tom for discovering and fixing that.
Comment 5 Dani Megert CLA 2015-03-26 09:12:27 EDT 
Tom, just to close on this: did you verify that the reported case in bug 416673 comment 0 is still fixed?
Comment 6 Thomas Schindl CLA 2015-03-27 04:15:59 EDT 
Dani - the code path I changed was only when you are coming from a clean state - the really important fix is at line 234 which ensures that when coming from a restored state we are having a window.

Anyways I just ran with the model from bug 416673 and things behave like they should
Comment 7 Markus Keller CLA 2015-11-23 14:48:45 EST 
This fix has been backported, see bug 482162 comment 5.