Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 462887

Summary: Split up the linting preferences into categories
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3    
Version: 8.0   
Target Milestone: 9.0   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 462889, 463013    
Bug Blocks:    
Attachments:
Description Flags
potential fix none

Description Michael Rennie CLA 2015-03-23 16:13:05 EDT 
Created attachment 251843 [details]
potential fix

I already updated the wiki https://wiki.eclipse.org/Orion/ESLint,

but we should also reorganize the linting preferences to make more sense to the end user, so hey have some idea of what kinds of thins the rules complain about.

The attached patch breaks the rule prefs into three categories:

1. Potential Programming Problems
2. Best Practices
3. Code Style
Comment 1 Michael Rennie CLA 2015-03-23 16:25:49 EDT 
The only problem I found with the patch is that the new groups are sorted by their name on the settings page, and not in the order I define them. I opened bug 462889 to address this.
Comment 2 Michael Rennie CLA 2015-03-24 15:42:07 EDT 
Fixed in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=cacb8b97bee5a4eec67e626ad7bb31d624e1fd5e

We can add any sorting later if needed (from fix for bug 462889)