Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 462665

Summary:	Remove references to Carbon in SWT Java code and comments
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	SWT	Assignee:	Lars Vogel <Lars.Vogel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtakov, arunkumar.thondapu, Lars.Vogel, lshanmug, sravankumarl
Version:	4.5	Keywords:	triaged
Target Milestone:	4.12 M3
Hardware:	PC
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/44605 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=943f51a97105ac775602b2d85dab479fde6bc88f https://git.eclipse.org/r/137791 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=f3e53cf7e6d2794b089e6cbe972dc0caae4a2ea1
Whiteboard:
Bug Depends on:	444725
Bug Blocks:

Description Lars Vogel

2015-03-20 07:40:14 EDT

Comment 1 Lars Vogel

2015-03-20 07:41:46 EDT

See Bug 444725.

Comment 2 Eclipse Genie

2015-03-25 10:05:43 EDT

New Gerrit change created: https://git.eclipse.org/r/44605

Comment 3 Eclipse Genie

2015-03-25 10:08:36 EDT

Gerrit change https://git.eclipse.org/r/44605 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=943f51a97105ac775602b2d85dab479fde6bc88f

Comment 4 Arun Thondapu

2015-04-22 12:41:39 EDT

Lars, it looks like there is more work needed here... should we continue on it post 4.5?

Comment 5 Lars Vogel

2015-04-22 13:41:40 EDT

Agree, let's move that to 4.6.

Comment 6 Sravan Kumar Lakkimsetti

2016-03-23 05:44:22 EDT

Hi Lars,

Do you intend to complete this work in M7?

Comment 7 Alexander Kurtakov

2016-04-20 12:54:35 EDT

Postpone to 4.7.

Comment 8 Arun Thondapu

2017-03-24 05:39:05 EDT

It will be good to complete this one.

Lars, do you intend to provide a patch for M7?

Comment 9 Lakshmi P Shanmugam

2017-05-22 04:50:59 EDT

Moving out of 4.7.

Comment 10 Lakshmi P Shanmugam

2019-02-13 04:43:55 EST

@Lars,
Do you plan to fix this for 4.11? If not, please retarget as required.

Comment 11 Lakshmi P Shanmugam

2019-02-19 03:28:03 EST

(In reply to Lakshmi Shanmugam from comment #10)
> @Lars,
> Do you plan to fix this for 4.11? If not, please retarget as required.

Resetting target.

Comment 12 Lars Vogel

2019-02-28 06:49:26 EST

(In reply to Lakshmi Shanmugam from comment #10)
> @Lars,
> Do you plan to fix this for 4.11? If not, please retarget as required.

Sorry, missed that comment. Will try to finish this for 4.12

Comment 13 Lars Vogel

2019-02-28 06:51:53 EST

Lakshmi, do we still use the 
System.getProperty("org.eclipse.swt.internal.carbon.smallFonts") property or can this also be removed?

Comment 14 Eclipse Genie

2019-02-28 06:58:19 EST

New Gerrit change created: https://git.eclipse.org/r/137791

Comment 15 Lakshmi P Shanmugam

2019-02-28 07:31:52 EST

(In reply to Eclipse Genie from comment #14)
> New Gerrit change created: https://git.eclipse.org/r/137791

(In reply to Lars Vogel from comment #13)
> Lakshmi, do we still use the 
> System.getProperty("org.eclipse.swt.internal.carbon.smallFonts") property or
> can this also be removed?

Yes, it's still used by platform UI code.

Comment 16 Eclipse Genie

2019-04-23 05:00:52 EDT

Gerrit change https://git.eclipse.org/r/137791 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=f3e53cf7e6d2794b089e6cbe972dc0caae4a2ea1

Comment 17 Lars Vogel

2019-04-23 05:02:16 EDT

Thanks, Lakshmi for the fast review. 

No more work planned from my side.