Bugzilla – Full Text Bug Listing
| Summary: | Remove (or at least extract) Movida-specific code | ||
|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Pierre-Charles David <pierre-charles.david> |
| Component: | Core | Assignee: | Pierre-Charles David <pierre-charles.david> |
| Status: | CLOSED FIXED | QA Contact: | Florian Barbin <florian.barbin> |
| Severity: | enhancement | ||
| Priority: | P4 | CC: | florian.barbin, maxime.porhel, pierre.guilet |
| Version: | 1.0.0M6 | Keywords: | triaged |
| Target Milestone: | 6.0.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/115686 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c07b653ced6294685d7f570a80d50bddb0b915d5 |
||
| Whiteboard: | |||
New Gerrit change created: https://git.eclipse.org/r/115686 Gerrit change https://git.eclipse.org/r/115686 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c07b653ced6294685d7f570a80d50bddb0b915d5 Fixed by c07b653ced6294685d7f570a80d50bddb0b915d5. Note that this is a purely internal code change, which should have no visible effect except for the (documented) removal of some APIs where never actually used. Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for details |
Movida was an experimental project which never reached a state where we could enable its features by default. As such, it is effectively dead weight. From a quick test, it looks like this could get rid of at least 17k SLOC, mostly in these areas: * the "contributions.ecore" metamodel and all its corresponding generated code. * all the runtime code used to interpret the contributions definitions. * the Movida static class, which served as a feature flag, leads to most of the places in the code with Movida-specific code branches that can be removed. * the alternative ViewpointRegistry implementation, and the split between ViewpointRegistry and the default ViewpointRegistryImpl, which because less useful with a single implementation. * the Viewpoint.{conflicts,reuses,customizes} references and associated generated code. * DialectServices.refreshEffectiveRepresentationDescription() and other APIs (if any) which were introduced for the Movida use case. * any other internal support code which was used only by the code being removed.