Bugzilla – Full Text Bug Listing
| Summary: | PropertySourceAdapterFactory is not null aware | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Reguel Wermelinger <reguel.wermelinger> | ||||
| Component: | GEF-Legacy GEF (MVC) | Assignee: | Alexander Nyßen <nyssen> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | nyssen | ||||
| Version: | 3.9.100 | ||||||
| Target Milestone: | 4.0.0 / 3.11.0 (Neon) M2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Thanks for having pointed that out. Could you please confirm that your contribution complies with the Certificate of Origin (http://www.eclipse.org/legal/CoO.php)? If you don't confirm CoO compliance, I will not be able to consume your patch. Yes the contribution complies with the Certificate of origin. But I don't know where I have to sign it... (In reply to Reguel Wermelinger from comment #3) > Yes the contribution complies with the Certificate of origin. > But I don't know where I have to sign it... You can't sign it. But each contribution that is not provided via Gerrit (which we not yet offer) has to contain a respective compliant-statement. As such, the above statement is all I need. I applied you patch and pushed the changes to origin/master. Resolving as fixed in 3.11.0 M2. |
Created attachment 251588 [details] NPE patch The org.eclipse.gef.internal.PropertySourceAdapterFactory.getAdapter(Object, Class) does not respect, that by Javadoc the AbstractEditParty.getModel() could return null. Therefore it could fail with an NPE.