Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 461991

Summary:

Preconditions not working for Double Click and Direct Edit tools

Product:

[Modeling] Sirius

Reporter:

Max Schettler <max.schettler>

Component:

Diagram

Assignee:

Jessy Mallet <jessy.mallet>

Status:

CLOSED FIXED

QA Contact:

Maxime Porhel <maxime.porhel>

Severity:

normal

Priority:

CC:

laurent.redor, maxime.porhel, steve.monnier

Version:

2.0.0

Keywords:

triaged

Target Milestone:

3.0.0M7

Hardware:

OS:

Linux

See Also:

https://git.eclipse.org/r/44439
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=42b9bff908ed51210a7a2a18b271612c53b5581a
https://git.eclipse.org/r/49917
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e43e59793d845d47ad0bc8015fabf13202b1d618

Whiteboard:

Attachments:

Description	Flags
Sample for reproduction	none

Description Max Schettler

2015-03-12 07:17:36 EDT

For me the precondition-expressions on both the Double Click as well as the Direct Edit tool are not working.

Steps to reproduce:
- Follow the Sirius "getting started" Tutorial until a Man/Person/Woman-Node has been specified
- Create a Double Click and Direct Edit tool that delete the corresponding element from the diagram and have "[false/]" as an expression
- Associate the created tools with the Node
- Create a diagram for the basicfamily sample
- Try to execute the tools by double-clicking or renaming the labels

The model elements will be removed from the diagram even though the precondition is not fulfilled.

Comment 1 Steve Monnier

2015-03-16 07:13:46 EDT

Created attachment 251579 [details]
Sample for reproduction

Here is a sample to reproduce. It is a diagram displaying EPackages of an ecore model. A double-click tool (with a remove task) and a direct edit tool, both with a [false/] precondition have been created. They are both unexpectedly usable.

Comment 2 Eclipse Genie

2015-03-24 05:56:28 EDT

New Gerrit change created: https://git.eclipse.org/r/44439

Comment 3 Eclipse Genie

2015-03-29 08:00:22 EDT

Gerrit change https://git.eclipse.org/r/44439 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=42b9bff908ed51210a7a2a18b271612c53b5581a

Comment 4 Laurent Redor

2015-03-29 08:01:42 EDT

Resolved with commit http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=42b9bff908ed51210a7a2a18b271612c53b5581a

Comment 5 Maxime Porhel

2015-05-21 08:40:04 EDT

Validated on Sirius 3.0.0 RC1

Comment 6 Eclipse Genie

2015-06-10 09:37:36 EDT

New Gerrit change created: https://git.eclipse.org/r/49917

Comment 7 Eclipse Genie

2015-06-11 08:29:56 EDT

Gerrit change https://git.eclipse.org/r/49917 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e43e59793d845d47ad0bc8015fabf13202b1d618

Comment 8 Pierre-Charles David

2015-06-24 11:17:18 EDT

Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.