Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 461866

Summary:	Change throw-error to 'no-throw-literal'
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	JS Tools	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	8.0
Target Milestone:	9.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2015-03-10 14:06:48 EDT

Since the 'throw-error' rule was implemented, ESLint has now its own version of this rule called 'no-throw-literal' [1].

Orion's linter should adopt the same rule name (and behavior, if there's any difference) so that we do not diverge too much from the upstream eslint project. 

[1] https://github.com/eslint/eslint/blob/master/docs/rules/no-throw-literal.md

Comment 1 Mark Macdonald

2015-03-10 17:47:51 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2c49d12

Comment 2 Mark Macdonald

2015-03-11 11:05:10 EDT

2nd commit, updates the NLS keys and the pref id for the rule.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=998a8c6

Comment 3 Mark Macdonald

2015-03-11 11:05:27 EDT

Note that the legacy pref id 'throw-error' is mapped to 'no-throw-literal', handling the migration case.