Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 461850

Summary:	[eslint] Add no-self-compare rule
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Olivier Thomann <Olivier_Thomann>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	curtis.windatt.public, Olivier_Thomann
Version:	8.0
Target Milestone:	11.0
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/62845 https://git.eclipse.org/r/62888 https://git.eclipse.org/r/62958 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bd7547982a06d3716c9171509eab3823cd0fcda2
Whiteboard:

Description Michael Rennie

2015-03-10 12:01:02 EDT

We should add the no-self-compare rule:

http://eslint.org/docs/rules/no-self-compare.html

Comment 1 Eclipse Genie

2015-12-16 10:48:24 EST

New Gerrit change created: https://git.eclipse.org/r/62845

Comment 2 Eclipse Genie

2015-12-16 20:38:42 EST

New Gerrit change created: https://git.eclipse.org/r/62888

Comment 3 Olivier Thomann

2015-12-16 20:40:11 EST

I abandonned https://git.eclipse.org/r/62845.
The last one is the good one to use.

Curtis, could you please review it?

Thanks.

Comment 4 Eclipse Genie

2015-12-17 13:58:50 EST

New Gerrit change created: https://git.eclipse.org/r/62958

Comment 5 Eclipse Genie

2015-12-17 14:30:47 EST

Gerrit change https://git.eclipse.org/r/62958 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bd7547982a06d3716c9171509eab3823cd0fcda2

Comment 6 Curtis Windatt

2015-12-17 14:39:28 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bd7547982a06d3716c9171509eab3823cd0fcda2
+1 Merged with master