Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 461838

Summary:	Resource#accept(IResourceProxyVisitor, int, int) should visit files in alphabetic order
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	Resources	Assignee:	Markus Keller <markus.kell.r>
Status:	VERIFIED FIXED	QA Contact:	Szymon Ptaszkiewicz <sptaszkiewicz>
Severity:	normal
Priority:	P3	CC:	daniel_megert, jarthana, sptaszkiewicz, stephan.herrmann
Version:	4.5
Target Milestone:	4.5 M7
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/43586 https://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=f334481779d0a0d85761605e516392186acbb789
Whiteboard:
Bug Depends on:
Bug Blocks:	461861, 463153

Description Markus Keller

2015-03-10 11:29:48 EDT

Resource#accept(IResourceProxyVisitor, int, int) should visit files in alphabetic order. 

ElementTreeIterator#iterate(IElementContentVisitor) and #doIteration(DataTreeNode, IElementContentVisitor) try to be smart and save a local variable by iterating backwards, but this violates KISS and basic client assumptions.

One effect is that file search in Eclipse reports elements in backwards order, which causes noise when elements are inserted at the top of the results view.

Comment 1 Eclipse Genie

2015-03-10 11:33:53 EDT

New Gerrit change created: https://git.eclipse.org/r/43586

Comment 2 Eclipse Genie

2015-03-25 09:12:29 EDT

Gerrit change https://git.eclipse.org/r/43586 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=f334481779d0a0d85761605e516392186acbb789

Comment 3 Szymon Ptaszkiewicz

2015-03-25 09:15:39 EDT

Fixed in master. Thanks, Markus!

Comment 4 Jay Arthanareeswaran

2015-03-30 01:24:00 EDT

This is causing failures in some JDT Core tests, see bug 463153.

Comment 5 Szymon Ptaszkiewicz

2015-04-02 10:32:31 EDT

Verified in I20150331-0800.