Bugzilla – Full Text Bug Listing
| Summary: | 4 api tool test fail in nightly build | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Vikas Chandra <Vikas.Chandra> |
| Component: | API Tools | Assignee: | Vikas Chandra <Vikas.Chandra> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | curtis.windatt.public, pascal |
| Version: | 4.5 | ||
| Target Milestone: | 4.5 M6 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Vikas Chandra
Works ok with Version: Mars (4.5) Build id: N20150309-1000 and latest PDE code Waiting for next build result. New 4 failure after fix to Bug 461653 was commited. I cant recreate this on my local machine. Could the commit to Bug 461653 cause this? The code I changed only impacts (In reply to Vikas Chandra from comment #2) > New 4 failure after fix to Bug 461653 was commited. > > I cant recreate this on my local machine. Could the commit to Bug 461653 > cause this? I doubt it because all the code changes relate to the export of products, and most of them are guarded by a test on the OS. I will download latest build and try to recreate on my machine. In N20150311-2000, there are 1042 errors on windows http://download.eclipse.org/eclipse/downloads/drops4/N20150311-2000/testresults/html/org.eclipse.pde.api.tools.tests_win32.win32.x86_7.0.html I am able to recreate 4 api tool error with new eclipse and clean workspace. For this case the bundle component.a_1.0.0 is not resolved because its required bundle org.eclipse.core.runtime doesnt resolve. org.eclipse.core.runtime doesn't resolve because one of its many require bundle doesn't resolve.
To see this issue, put a conditional breakpoint of
bundle.toString().contains("a_1.") or bundle.toString().contains("org.eclipse.core.runtime")
on 1st line of
org.eclipse.osgi.internal.module.ResolverImpl::resolveBundle(ResolverBundle bundle, List<ResolverBundle> cycle) {
(In reply to Vikas Chandra from comment #6) > I am able to recreate 4 api tool error with new eclipse and clean workspace. After updating to the latest I build, I cannot reproduce the test failures. The ApiBaselineTests are part of the API Tools Test Suite, which gets the list of bundles from a VM argument (-DrequiredBundles). Can you determine why the core.runtime bundle couldn't resolve? (In reply to Curtis Windatt from comment #8) > (In reply to Vikas Chandra from comment #6) > > I am able to recreate 4 api tool error with new eclipse and clean workspace. > > After updating to the latest I build, I cannot reproduce the test failures. > The ApiBaselineTests are part of the API Tools Test Suite, which gets the > list of bundles from a VM argument (-DrequiredBundles). Can you determine > why the core.runtime bundle couldn't resolve? I can reproduce now. When I updated it did not garbage collect the old version of org.eclipse.core.contenttype from my plug-ins folder. The state could still resolve by using the old version. I simply deleted the old version to reproduce. The failures are caused by org.eclipse.core.contenttype recently moving to a 1.7 BREE. The baseline tests are not run as a plug-in test, so they don't have access to the full list of EE profiles from OSGi. Instead they use a list stored inside the API Tools plugin: org.eclipse.pde.api.tools.internal.util.profiles There is no 1.7 profile there so the baseline can't resolve http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=c8bf2e45866e29a04df7cc83ceb54b69f2e34b14 I added the 1.7 and 1.8 profiles from the OSGi plug-in to the list inside api tools. Also added some comments to the tests to help make tracking down issues like this faster in the future. (In reply to Curtis Windatt from comment #10) > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=c8bf2e45866e29a04df7cc83ceb54b69f2e34b14 > I added the 1.7 and 1.8 profiles from the OSGi plug-in to the list inside > api tools. Also added some comments to the tests to help make tracking down > issues like this faster in the future. After cleaning up some changes I made to the TestHelper (where it creates a dummy EE profile), the failures return. Perhaps we need to have both the profile in the api tools plug-in as well as change the test's EE to a higher profile. Vikas, can you please check this before M6? Changing the Dee.class.library.level=JavaSE-1.7" in getEEDescriptionFile for TestSuiteHelper fixes this. A commit will follow. The commit id corresponding to previous comment is http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=05ba744d942c4374832c583ed1ea1ddaca0d1eda Verified in 4.5 N20150313-2000 See http://download.eclipse.org/eclipse/downloads/drops4/N20150313-2000/testResults.php |