Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 461604

Summary:	[IE and Safari] editor styles page accepts and persists invalid colour strings
Product:	[ECD] Orion	Reporter:	Grant Gayed <grant_gayed>
Component:	Client	Assignee:	Umar Bolatov <ubolatov>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	9.0
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/43454 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2f9966ed7e9c8f400a1fe73fb720510be755eba2
Whiteboard:

Description Grant Gayed

2015-03-06 10:58:28 EST

Now that this page has text input elements for its colours I can type anything in them and the values are persisted.  It's good that an invalid value seems to just be ignored in the colour rendering, but it's still confusing to look at a list of colours and see invalid values like "#qrst" and "asdf" being stored and then later retrieved.

Comment 1 Grant Gayed

2015-03-06 11:22:25 EST

Adding Safari to the title since it also has text-based color input fields.

Ideally when clicking out of a text with an invalid colour value the text's value would be reverted to its initial valid value.

Comment 2 Eclipse Genie

2015-03-09 11:49:30 EDT

New Gerrit change created: https://git.eclipse.org/r/43454

Comment 3 Eclipse Genie

2015-03-10 16:23:11 EDT

Gerrit change https://git.eclipse.org/r/43454 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2f9966ed7e9c8f400a1fe73fb720510be755eba2

Comment 4 Grant Gayed

2015-03-10 16:38:10 EDT

Released Umar's fix ( http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2f9966ed7e9c8f400a1fe73fb720510be755eba2 ) and a small follow-up ( http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=58a46aa2cf80bc252a40c18e8af02f617a2af309 ).