Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 461600

Summary:	Sirius preferences are not persisted over eclipse restarts.
Product:	[Modeling] Sirius	Reporter:	Wilbert Alberts <wilbert.alberts>
Component:	Core	Assignee:	Project inbox <sirius.core-inbox>
Status:	CLOSED FIXED	QA Contact:	Jessy Mallet <jessy.mallet>
Severity:	normal
Priority:	P3	CC:	belqassim.djafer, florian.barbin, jessy.mallet, laurent.redor, maxime.porhel, pierre-charles.david, steve.monnier, wilbert.alberts
Version:	2.0.4	Keywords:	triaged
Target Milestone:	3.1.0
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/51865 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=adaf3820b9c9c29dc6c0ba58dbcd1a9286fbbf2a
Whiteboard:
Bug Depends on:
Bug Blocks:	475817

Description Wilbert Alberts

2015-03-06 10:08:17 EST

Changes to Sirius related preferences (like whether to start a diagram 'synchronized' or not) are not persisted over eclipse restarts.

Way to reproduce: 
1) start eclipse
2) open the preferences and modify the Sirius Diagram preference 'Synchronized mode for new diagrams'
3) close and restart eclipse
4) open the preferences and note that the change you made in 2) has not been persisted.

Comment 1 Laurent Redor

2015-07-02 06:21:43 EDT

Further technical information:
* The corresponding preference is org.eclipse.sirius.diagram.tools.internal.preferences.SiriusDiagramInternalPreferencesKeys.PREF_SYNCHRONIZE_DIAGRAM_ON_CREATION
* It is displayed in UI with org.eclipse.sirius.diagram.ui.internal.preferences.DiagramGeneralPreferencePage.

Comment 2 Belqassim Djafer

2015-07-13 04:57:49 EDT

This issue also exists in Sirius 3.0, Sirius 2.0 and 1.0.1 in different target platforms (mars, luna and kepler for 1.0.1)

Comment 3 Belqassim Djafer

2015-07-13 11:14:15 EDT

This issue is also present with the preference "Move unlinked notes during layout"

In org.eclipse.sirius.diagram.ui.internal.preferences.DiagramGeneralPreferencePage.initialize(), after each load of a BooleanFieldEditor, the boolean value change to the default value even if this boolean value is correctly specified in the preferenceStore.

Comment 4 Eclipse Genie

2015-07-13 11:22:41 EDT

New Gerrit change created: https://git.eclipse.org/r/51865

Comment 5 Maxime Porhel

2015-07-27 11:04:27 EDT

Header presentation choice in DiagramAppearancePreferencePage is also impacted

Comment 6 Maxime Porhel

2015-07-27 11:31:01 EDT

The issue comes from the DiagramPlugin's preference store: the plugin is not an UI plugin, nothing has been generated to serialize/save the preferences state. 

See the comment on the first patch set.

Comment 7 Maxime Porhel

2015-07-28 03:05:30 EDT

SiriusDiagramCorePreferences.PREF_ENABLE_OVERRIDE and SiriusDiagramCorePreferences.PREF_LINE_STYLE are also impacted.

Comment 8 Eclipse Genie

2015-08-04 09:20:32 EDT

Gerrit change https://git.eclipse.org/r/51865 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=adaf3820b9c9c29dc6c0ba58dbcd1a9286fbbf2a

Comment 9 Florian Barbin

2015-08-04 10:58:34 EDT

Fixed on master

Comment 10 Jessy Mallet

2015-09-28 08:24:32 EDT

Validated with Sirius 3.1.0.201509241504

Comment 11 Pierre-Charles David

2015-10-16 09:12:17 EDT

Available in Sirius 3.1.0.