Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 461557

Summary:	Editor update needed after control/uncontrol moving representation concerning opened editors
Product:	[Modeling] Sirius	Reporter:	Steve Monnier <steve.monnier>
Component:	Core	Assignee:	Steve Monnier <steve.monnier>
Status:	CLOSED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	belqassim.djafer, laurent.redor, maxime.porhel, pierre-charles.david
Version:	unspecified	Keywords:	triaged
Target Milestone:	3.0.0M6
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/43287 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=40283e68d802bcea182a3b022d66fdca596743d6 https://git.eclipse.org/r/43325 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=74814928c41228f302e0babfdd8f76ded9678676 https://git.eclipse.org/r/44188 https://git.eclipse.org/r/44234 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a93503531c1e93c6fb075968b55db97d23df87bb https://git.eclipse.org/r/44860 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=262aedbb52c34dc54089a557ccfd6837ee2e881d https://git.eclipse.org/r/45465 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0a834daf06d7635fd03360eaaaafd3e10be4487a
Whiteboard:
Bug Depends on:	460351
Bug Blocks:

Description Steve Monnier

2015-03-06 03:48:19 EST

+++ This bug was initially created as a clone of Bug #460351 +++

Controlling a semantic element that contains DRepresentation currently opened in editors should update these editors to avoid having to close/reopen them.
Note that in an older version, these editors were closed.

Comment 1 Eclipse Genie

2015-03-06 04:35:45 EST

New Gerrit change created: https://git.eclipse.org/r/43287

Comment 2 Eclipse Genie

2015-03-06 08:06:00 EST

Gerrit change https://git.eclipse.org/r/43287 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=40283e68d802bcea182a3b022d66fdca596743d6

Comment 3 Eclipse Genie

2015-03-06 11:05:50 EST

New Gerrit change created: https://git.eclipse.org/r/43325

Comment 4 Eclipse Genie

2015-03-06 11:09:42 EST

Gerrit change https://git.eclipse.org/r/43325 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=74814928c41228f302e0babfdd8f76ded9678676

Comment 5 Maxime Porhel

2015-03-06 11:28:19 EST

Steve, could you add some new swtbot tests to check the behavior of the goto marker navigation: 

Take a diagram whose VSM has a validation rule. 
Create en invalid model and validate the diagram. 

Test1: diagram open - double clic on the marker: the invalid element has to be selected
Test2: the same but when you double clic, the focus is set on another editor. 
Test3: diagram closed - double clic on the marker: the invalid element is selected after diagram opening
Test4: session closed then test 3.

Comment 6 Eclipse Genie

2015-03-19 12:12:47 EDT

New Gerrit change created: https://git.eclipse.org/r/44188

Comment 7 Eclipse Genie

2015-03-20 06:51:58 EDT

New Gerrit change created: https://git.eclipse.org/r/44234

Comment 8 Eclipse Genie

2015-03-20 09:30:25 EDT

Gerrit change https://git.eclipse.org/r/44234 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a93503531c1e93c6fb075968b55db97d23df87bb

Comment 9 Steve Monnier

2015-03-20 09:31:32 EDT

During validation, use the sample from the first gerrit
- open a diagram
- control an element and add the diagram to the controlled representation
- validate that the diagram is still open and usable by creating a new element on it
- uncontrol and validate the same way
- repeat with a tree and a table representation
+ Validate the 4 tests about markers listed by Maxime in the fifth comment

Comment 10 Eclipse Genie

2015-03-30 11:45:28 EDT

New Gerrit change created: https://git.eclipse.org/r/44860

Comment 11 Eclipse Genie

2015-03-30 11:45:50 EDT

Gerrit change https://git.eclipse.org/r/44860 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=262aedbb52c34dc54089a557ccfd6837ee2e881d

Comment 12 Eclipse Genie

2015-04-08 10:15:03 EDT

New Gerrit change created: https://git.eclipse.org/r/45465

Comment 13 Eclipse Genie

2015-04-08 12:10:39 EDT

Gerrit change https://git.eclipse.org/r/45465 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0a834daf06d7635fd03360eaaaafd3e10be4487a

Comment 14 Belqassim Djafer

2015-04-14 03:59:45 EDT

Verified on Sirius 3.0.0M6

Comment 15 Pierre-Charles David

2015-06-24 11:17:24 EDT

Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.