Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 461549

Summary: [patch] [target] Dont increment sequence number during reload and provide tooltips for reload and update
Product: [Eclipse Project] PDE Reporter: Vikas Chandra <Vikas.Chandra>
Component: UIAssignee: Markus Kuppe <bugs.eclipse.org>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: bugs.eclipse.org, christian.pontesegger, curtis.windatt.public, daniel_megert, gunnar, malaperle, peter.kullmann, pwebster, rico.scholz, Vikas.Chandra, wim.jongman
Version: 4.4   
Target Milestone: 4.5 M6   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on: 439034, 441190    
Bug Blocks: 462214    
Attachments:
Description Flags
Patch for not increasing sequence number by Markus K none

Description Vikas Chandra CLA 2015-03-05 22:56:56 EST 
+++ This bug was initially created as a clone of Bug #441190 +++

Additional discussion on Bug 439034.  We should consider having a reload button that clears the cached p2 profile, allowing the p2 sites to query the remote repositories.

We now allow this after a successful update as well as when the resolution returned an error status.

+++ This bug was initially created as a clone of Bug #439034 +++
Comment 1 Marc-André Laperle CLA 2015-03-05 23:04:15 EST 
I think that would be great!
Comment 2 Wim Jongman CLA 2015-03-06 04:30:30 EST 
There is also a reload button in the "Install/Update/Available Software Site" preferences. Is this related to the things you try to achieve here? If not please ignore.
Comment 3 Vikas Chandra CLA 2015-03-11 07:53:14 EDT 
Created attachment 251461 [details]
Patch for not increasing sequence number by Markus K
Comment 4 Vikas Chandra CLA 2015-03-11 07:54:31 EDT 
With this patch, scenario of comment#7 in bug 441190 doesnt work.
Comment 5 Curtis Windatt CLA 2015-03-11 09:45:40 EDT 
(In reply to Vikas Chandra from comment #4)
> With this patch, scenario of comment#7 in bug 441190 doesnt work.

Why doesn't that case work?  Is a resolve not getting started?  Or because while the sequence number is wrong, the basic contents still match so the cache is still treated as valid.  If it is the latter, we could a) Delete the cache on reload or b) Set the cache sequence number to a specific value which would indicate the cache is invalid and should be deleted on the next resolve/synchronize.
Comment 6 Vikas Chandra CLA 2015-03-16 05:48:32 EDT 
My bad !

It works fine. 

Committed via commit id

https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=8952937e7f3d89ad871dcdb9e139857b2fc5b864
Comment 8 Vikas Chandra CLA 2015-03-16 07:04:00 EDT 
Only minor issue of Bug 462214 - [target] Reload dirties the target editor may be remaining. I suspect it has an easy fix.
Comment 9 Vikas Chandra CLA 2015-03-16 07:05:32 EDT 
See git commits in the last 2 comments.
Comment 10 Vikas Chandra CLA 2015-03-19 01:44:11 EDT 
Version: Mars (4.5)
Build id: I20150317-2000