Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 461225

Summary:	/** @callback */ is no longer making unused parameter warnings go away
Product:	[ECD] Orion	Reporter:	Grant Gayed <grant_gayed>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Michael_Rennie
Version:	8.0
Target Milestone:	9.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Grant Gayed

2015-03-02 12:36:51 EST

Open markdownEditor.js to see this, there are various places where this warning is shown in spite of the preceeding /** @callback */ annotations (which were originally generated by invoking quick fixes).  I'm reasonably sure there was a time not long ago when this was working.

Comment 1 Michael Rennie

2015-03-02 16:12:57 EST

This is probably some fall out from the parser update. They broke some of the support for attaching comments in the parser:

https://github.com/jquery/esprima/issues/1071

I guess comments are no longer attached to the FunctionExpression node anymore

Comment 2 Michael Rennie

2015-03-02 16:46:12 EST

Fix: 

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a9d3c1c328aaced8ebcbf60e5f921ca57cffb646

The comments for FunctionExpressions are all over the place now. In one case they are attached to the key of the property (of the object expression) and in another case they are attached to the first parameter of the function expression when it is not assigned to anything (a function expression passed in as a param).