Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 460706

Summary:	Provide a dialog to select image paths in the VSM editor
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Core	Assignee:	Benjamin Grouhan <benjamin.grouhan>
Status:	CLOSED FIXED	QA Contact:	Belqassim Djafer <belqassim.djafer>
Severity:	enhancement
Priority:	P3	CC:	belqassim.djafer, laurent.fasani
Version:	1.0.0M6	Keywords:	triaged
Target Milestone:	3.0.0
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/46578 https://git.eclipse.org/r/46577 https://git.eclipse.org/r/46579 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f0baa42d367435bdc99efd6a51a7847932191b94 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=766e9850e0dfaeb7443a89cf504664506d07d4dc https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2fa80f3765671d7d3b0b22cf55a2f21d98109cde https://git.eclipse.org/r/48355 https://git.eclipse.org/r/48453
Whiteboard:	needtest

Description Pierre-Charles David

2015-02-24 10:00:41 EST

Several attributes in the VSM correspond to image paths (from the workspace or from a plugin), but the current UI is cumbersome and error-prone, as it is a naked text field.

Thess text fields should be augmented with a button opening a dialog where the user can select images from the workspace and/or from installed plug-ins.

Ideally the dialog should offer a preview of the image but that is optional (not sure if SWT supports this).

Comment 1 Eclipse Genie

2015-04-27 12:12:37 EDT

New Gerrit change created: https://git.eclipse.org/r/46578

Comment 2 Eclipse Genie

2015-04-27 12:12:38 EDT

New Gerrit change created: https://git.eclipse.org/r/46577

Comment 3 Eclipse Genie

2015-04-27 12:12:39 EDT

New Gerrit change created: https://git.eclipse.org/r/46579

Comment 4 Eclipse Genie

2015-05-12 04:13:40 EDT

Gerrit change https://git.eclipse.org/r/46577 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f0baa42d367435bdc99efd6a51a7847932191b94

Comment 5 Eclipse Genie

2015-05-12 04:13:55 EDT

Gerrit change https://git.eclipse.org/r/46578 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=766e9850e0dfaeb7443a89cf504664506d07d4dc

Comment 6 Eclipse Genie

2015-05-12 04:14:06 EDT

Gerrit change https://git.eclipse.org/r/46579 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2fa80f3765671d7d3b0b22cf55a2f21d98109cde

Comment 7 Pierre-Charles David

2015-05-13 04:17:55 EDT

The code itself is merged, but I'm not closing the issue yet as there is no  automated test for the new feature.

Comment 8 Eclipse Genie

2015-05-21 07:08:15 EDT

New Gerrit change created: https://git.eclipse.org/r/48355

Comment 9 Eclipse Genie

2015-05-22 07:55:58 EDT

New Gerrit change created: https://git.eclipse.org/r/48453

Comment 10 Belqassim Djafer

2015-05-27 05:58:04 EDT

Verified with Sirius 3.0.0 RC1

Comment 11 Pierre-Charles David

2015-05-29 04:41:22 EDT

I'm closing this to get a more precise view of what's left to do for 3.0.0. The feature itself is done, the only thing missing is to push the automated test (in development), and the "needtest" flag is there to remind us of that.

Comment 12 Pierre-Charles David

2015-06-24 11:15:27 EDT

Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.