Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 460603

Summary: Do not decorate the viewpoint icons for viewpoints loaded from plugins
Product: [Modeling] Sirius Reporter: Pierre-Charles David <pierre-charles.david>
Component: CoreAssignee: Maxime Porhel <maxime.porhel>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: laurent.redor, maxime.porhel
Version: 1.0.0M6Keywords: triaged
Target Milestone: 3.0.0M6   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/43284
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=687a082c604c66d1433c90d25734bec75a061f2d
https://git.eclipse.org/r/48864
https://git.eclipse.org/r/48868
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2ce62244436a7e8b78ec08cfb3492f28e88d5fcb
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3ebbbd60de958b88c8c50d2335775165be034c9b
Whiteboard:

Description Pierre-Charles David CLA 2015-02-23 09:41:18 EST 
Currently the Viewpoint Selection Dialog adds a "plug-in" decorator on top of the icons of Viewpoint whose definition comes from deployed plug-ins, as opposed to the ones that come from VSMs in the workspace. This is backward: in normal usage by end-users, all the VSMs will be loaded from plug-ins and will thus have this decorator, which does not looks particularly nice and hides any user-defined icon below.

In practive the only users who will have both kind of VSMs and need to distinguish between them are the specifiers. It would be better if end-users (by far the most numerous) had a nice and clean UI, and only specifier (who are advanced users) had the additional info available.

So this ticket is about inverting the current logic
* no decorator for Viewpoint which are loaded from deployed plug-ins/bundles;
* a "workspace" decorator (maybe the Eclipse project icon) for Viewpoints which are loaded from the current workspace.

Note that there may be other places concerned beside just the Viewpoint Selection Dialog.
Comment 1 Eclipse Genie CLA 2015-03-06 03:45:35 EST 
New Gerrit change created: https://git.eclipse.org/r/43284
Comment 2 Maxime Porhel CLA 2015-03-06 06:00:07 EST 
The Viewpoint selection wizard page (org.eclipse.sirius.ui.tools.api.wizards.page.ViewpointsSelectionWizardPage) also have to be modified. 

It is at least used in Ecore Tools in the Ecore Modeling wizard.
Comment 4 Laurent Redor CLA 2015-03-12 09:13:52 EDT 
Resolved with commit of comment 3
Comment 5 Belqassim Djafer CLA 2015-04-13 11:19:32 EDT 
Verified on Sirius 3.0.0M6
Comment 6 Maxime Porhel CLA 2015-05-28 09:14:17 EDT 
See org.eclipse.sirius.ui.business.api.viewpoint.ViewpointSelection.ViewpointsTableLabelProvider.getEnhancedImage(Image, Viewpoint)  

The icon to use as decorator has been modified but not the preceding if: we do not want see decorate the viewpoints from plugins any more. 

Compare the test with other modifications made in commit http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=687a082c604c66d1433c90d25734bec75a061f2d ViewpointSelectionDialog and ViewpointSelectionDialogWizardPage
Comment 7 Eclipse Genie CLA 2015-05-28 09:27:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/48864
Comment 8 Eclipse Genie CLA 2015-05-28 10:06:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/48868
Comment 11 Maxime Porhel CLA 2015-05-29 03:08:36 EDT 
Regressions found during validation have been corrected.
 . Viewpoint specified icon (VSM) is used in the viewpoint selection dialogs
 . Folder decorator is used in wizard page when Viewpoint is not from plugin
Comment 12 Pierre-Charles David CLA 2015-06-24 11:14:54 EDT 
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.