Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 460468

Summary: [parser] Update to Esprima 2.0
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: mamacdon, Mike_Wilson, simon_kaegi
Version: 8.0   
Target Milestone: 9.0   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 460728    

Description Michael Rennie CLA 2015-02-20 12:54:48 EST
Once they tag and release version 2.1 we need to update: 
https://github.com/jquery/esprima/issues/1067

This branch has almost the tip of Esptrima master in it:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/log/?h=esprima2_0_0

Once they officially release 2.1 I will open the CQ and merge the branch.

I will also need to fix: https://github.com/jquery/esprima/issues/1071 if i does not make it into 2.1 as it cause a lot of test failures.
Comment 1 Michael Rennie CLA 2015-02-23 15:26:45 EST
The branch contains a complete Orion-ized version for testing.

All unit tests are passing and smoke testing did not reveal any regressions yet.

The branch also contains a workaround for https://github.com/jquery/esprima/issues/1071
Comment 2 Michael Rennie CLA 2015-02-23 15:56:25 EST
Since version 2.0 is only 12 commits behind master, I opened a CQ for version 2.0.0:

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9300.

The branch will be simple to update to the CQ version
Comment 3 Michael Rennie CLA 2015-02-26 11:05:21 EST
The CQ is approved and the new version has been pushed to master:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0a26ade22c4bc9a28c98b612512548c72a2bb3c4

All unit tests pass and smoke testing has not found any regressions so far.

Any new issues can be raised in their own bugs.