Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 460351

Summary:	Editor update needed after control/uncontrol moving representation concerning opened editors
Product:	[Modeling] Sirius	Reporter:	Steve Monnier <steve.monnier>
Component:	Core	Assignee:	Steve Monnier <steve.monnier>
Status:	CLOSED FIXED	QA Contact:	Belqassim Djafer <belqassim.djafer>
Severity:	normal
Priority:	P3	CC:	laurent.redor, maxime.porhel
Version:	2.0.4	Keywords:	triaged
Target Milestone:	2.0.5
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/42331 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f0f93799f89addb9cb55e8103bc83120fc69a8b9 https://git.eclipse.org/r/44188 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=cbba085ccdd7ee74b09ad739dafa8a9b28790f35 https://git.eclipse.org/r/45480 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=91a92b543a5218652300823a764769a4a2cc9866
Whiteboard:
Bug Depends on:
Bug Blocks:	461557

Description Steve Monnier

2015-02-19 10:57:41 EST

Controlling a semantic element that contains DRepresentation currently opened in editors should update these editors to avoid having to close/reopen them.
Note that in an older version, these editors were closed.

Comment 1 Eclipse Genie

2015-02-20 12:55:05 EST

New Gerrit change created: https://git.eclipse.org/r/42331

Comment 2 Steve Monnier

2015-02-20 12:56:33 EST

Here is a gerrit review https://git.eclipse.org/r/42331 The remaining task is to finish the SWTBot tests for the tree representation case

Comment 3 Eclipse Genie

2015-03-06 03:40:06 EST

Gerrit change https://git.eclipse.org/r/42331 was merged to [v2.0.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f0f93799f89addb9cb55e8103bc83120fc69a8b9

Comment 4 Steve Monnier

2015-03-06 03:41:23 EST

Fixed

Comment 5 Maxime Porhel

2015-03-06 11:10:31 EST

Steve you need to backport the patch correcting the NPE in case of goto marker navigation when the editor is closed. See Bug 461557

Comment 6 Eclipse Genie

2015-03-20 06:28:25 EDT

Gerrit change https://git.eclipse.org/r/44188 was merged to [v2.0.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=cbba085ccdd7ee74b09ad739dafa8a9b28790f35

Comment 7 Steve Monnier

2015-03-20 06:36:26 EDT

During validation, use the sample from the first gerrit
- open a diagram
- control an element and add the diagram to the controlled representation
- validate that the diagram is still open and usable by creating a new element on it
- uncontrol and validate the same way
- repeat with a tree and a table representation
+ Validate the 4 tests about markers listed by Maxime in 461557

Comment 8 Laurent Redor

2015-03-31 03:36:50 EDT

Verified on Sirius 2.0.5 [1]

[1] http://download.eclipse.org/sirius/updates/stable/2.0.5-S20150331-000124/luna

Comment 9 Laurent Redor

2015-03-31 10:20:59 EDT

Available in Sirius 2.0.5.

Comment 10 Eclipse Genie

2015-04-08 12:11:34 EDT

New Gerrit change created: https://git.eclipse.org/r/45480

Comment 11 Eclipse Genie

2015-04-08 12:11:46 EDT

Gerrit change https://git.eclipse.org/r/45480 was merged to [v2.0.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=91a92b543a5218652300823a764769a4a2cc9866