Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 459892

Summary: updateLocalization fails when application has no MainMenu.
Product: [RT] RAP Reporter: Thorsten Mueller <Thorsten.Mueller>
Component: IncubatorAssignee: Project Inbox <rap.incubator-inbox>
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: P3 CC: rsternberg
Version: 2.3   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Eclipse Screenshot none

Description Thorsten Mueller CLA 2015-02-13 09:05:31 EST
Created attachment 250785 [details]
Eclipse Screenshot

There seems to be a bug with the org.eclipse.e4.ui.internal.LocalChangeServiceImpl class in the e4-RAP incubator project. The function updateLocalization tries to call updateLocalization for a MainMenu when the iterated element is of type MWindow. In our case, we don't have a MainMenu (getMainMenu returning null) which results in a NullReferenceException.
It should be easy to fix this as there only needs to be check if a MainMenu is present.
Comment 1 Ralf Sternberg CLA 2015-02-16 12:37:04 EST
Is your target up to date? The actual source code seems to have a null check already:

http://git.eclipse.org/c/rap/incubator/org.eclipse.rap.incubator.e4.git/tree/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/LocaleChangeServiceImpl.java#n116
Comment 2 Thorsten Mueller CLA 2015-02-18 09:17:01 EST
Thanks Ralf for your feedback - you're right. Our target platform hasn't been updated for some time so we didn't recognize that this issue doesn't exist any more.

Bug can be closed.
Comment 3 Ralf Sternberg CLA 2015-02-18 10:47:03 EST
Thanks for the update, Thorsten! Closing.