Bugzilla – Full Text Bug Listing
| Summary: | Integrate eclipse.platform.ui.tools Git repo into platform build | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> |
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, david_williams, jhelming, Lars.Vogel, olivier.prouvost, wim.jongman |
| Version: | 4.5 | ||
| Target Milestone: | 4.5 M7 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://git.eclipse.org/r/44352 https://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=1b39eebf47928dd521e57ebe2f6b7991ee53cb3d |
||
| Whiteboard: | |||
| Bug Depends on: | 452061, 459798, 462817, 463913 | ||
| Bug Blocks: | 452693, 460560, 463649, 463856, 464242, 464243 | ||
|
Description
Lars Vogel
New Gerrit change created: https://git.eclipse.org/r/44352 Gerrit change https://git.eclipse.org/r/44352 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=1b39eebf47928dd521e57ebe2f6b7991ee53cb3d David, the build works now. What is the correct way to add this repository to our aggregator build? (In reply to Lars Vogel from comment #3) > David, the build works now. What is the correct way to add this repository > to our aggregator build? There's about 3 spots that need a modification. I can add them this week, and we'll try a nightly soon. In case you are curious, there's a "sreams/repositories.txt" file, in aggregator. Added to the "root pom" in its module list, and the feature (I assume, there's just one?) added in the "categories.xml" file of the "repository" section, that is, eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository Plus, I'll have to hand edit our "categories" repo at update site, to put in the "Tools" category. I think that's it. I was pleased to see that e4Build id already has access to it ... well ... at least according to it's file access list (you know, we tag each I-build). Assuming you have same "hooks" as the rest of the platform repositories, it should work. Another change, I had forgotten about, is that eclipse.platform.ui.tools will have to be added as a submodule of aggregater. I plan to do that later today, if my local tests pan out. I do see one oddity, when loaded in my workspace. I see ModelEditor.java has a compile error, saying that import org.eclipse.e4.ui.workbench.swt.internal.copy.FilteredTree; can not be found. And, FilteredTree is used later in the code, so actual compile error, not just an unused import. You do not get this, I assume? Just wondering if I'm missing something from my workspace? Or ... what? Well, I'll see how my "local test build" goes, and if it looks at all correct, compile error or not, I'll make the changes so will be into night's N-build. Yes, I get the same compile error in my local test build. ... so I assume you are still ready for "tonight" (8 PM Eastern) and will fix that? Under that assumption, I'll go ahead and add you as a submodule, and make the other changes to "pull you into a build". (we can always remove your "module" if you need a few days.) After all this is working ... "we" should talk more about docs? unit tests? and getting those integrated. (In reply to David Williams from comment #6) > Yes, I get the same compile error in my local test build. ... so I assume > you are still ready for "tonight" (8 PM Eastern) and will fix that? > > Under that assumption, I'll go ahead and add you as a submodule, and make > the other changes to "pull you into a build". Thanks for your work David. I reverted the change in Bug 450914 and it should compile again. I do a proper fix once we have the build running. commit to make submodule: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=e7575e21f1bcb853b9ab92268c9063ab8e955254 commit to "make build" http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=bfc82792a01680e20a89f63070caac633ba11f91 = = = = = = = These issues may deserve their own bugs, but I'll mention them here, and let you decided. - feature should use "standard, shared license". - feature should no have any "updatesites" listed. - feature name still says "(Incubation)" which I believe is no longer true. Good luck! Just to document it, here's a commit that shows the addition to the category on the download server: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=bfe1ddc4624ba44f47c746a2dc3b82ff8bee1e6f (We do not build or deploy these in any way, other than "by hand" ... but, store in Git for persistence and have a long term record that's easily accessible). You can't see it in the patch, but the name and description are: Eclipse Tests, Examples, and Extras Collection of Misc. Features, such as unit tests, examples, and compatibility features not shipped as part of main SDK, but which some people may desire in creating products based on previous versions of Eclipse. (In reply to David Williams from comment #9) > You can't see it in the patch, but the name and description are: > > Eclipse Tests, Examples, and Extras > > Collection of Misc. Features, such as unit tests, examples, and > compatibility features not shipped as part of main SDK, but which some > people may desire in creating products based on previous versions of Eclipse. Thanks David. Can I adjust this name and description? Currently it contains only tools for e4 development, so maybe a better name is: "Eclipse platform tools for e4 development" "Collection of tools and wizard to develop Eclipse 4 applications." (In reply to Lars Vogel from comment #10) > "Collection of tools and wizard to develop Eclipse 4 applications." "Collection of tools and wizard to develop Eclipse 4 components and applications." Just to be sure: The e4 tools are part of the platform SDK now and will therefore be part of all EPPs containing it? (In reply to Jonas Helming from comment #12) > Just to be sure: The e4 tools are part of the platform SDK now and will > therefore be part of all EPPs containing it? I'm not familiar with the EPP setup but I think they would need to add our new feature. See for example Bug 460560. I assume we would need similar bug reports for the other EPPs. (In reply to Jonas Helming from comment #12) > Just to be sure: The e4 tools are part of the platform SDK now and will > therefore be part of all EPPs containing it? To correct terminology, it is not "part of SDK" it is simply in the Eclipse Platform project repository. (In reply to Lars Vogel from comment #13) > (In reply to Jonas Helming from comment #12) > > Just to be sure: The e4 tools are part of the platform SDK now and will > > therefore be part of all EPPs containing it? > > I'm not familiar with the EPP setup but I think they would need to add our > new feature. See for example Bug 460560. I assume we would need similar bug > reports for the other EPPs. Correct. Will be nothing automatic about it, and will need to convince "Package owners" ... the first step of which is to up an EPP bug. (And, just to be realistic, there is likely to be "push back", since a lot of people have been wanting to add their stuff to EPP packages lately ... and, getting push back :) (In reply to David Williams from comment #14) > (In reply to Jonas Helming from comment #12) > Correct. Will be nothing automatic about it, and will need to convince > "Package owners" ... the first step of which is to up an EPP bug. (And, just > to be realistic, there is likely to be "push back", since a lot of people > have been wanting to add their stuff to EPP packages lately ... and, getting > push back :) Jonas, can you follow up on the integration with EPP? We have already Bug 452693 or the committers EPP but I think the RCP / RAP package would also make sense. Yes, I will do it for RCP and also Modeling (In reply to Jonas Helming from comment #16) > Yes, I will do it for RCP and also Modeling I should clarify, before it can be in an EPP package, it has to be in the Sim. Release repo, and it currently is not. If you want it to be please let me know. I'm guessing it'd go in them category as where we put the API Tools, but let me know what you'd like. (It would not have to be in a category, to be in Sim. Release repo, but, I'm guessing you'd want it to be ... again, let me know, probably a new bug in Cross Project's component would be best). (In reply to David Williams from comment #17) > (In reply to Jonas Helming from comment #16) > > Yes, I will do it for RCP and also Modeling > > I should clarify, before it can be in an EPP package, it has to be in the > Sim. Release repo, and it currently is not. If you want it to be please let > me know. Yes, please this was the whole purpose of the move from e4 to platform.ui. I'm guessing it'd go in them category as where we put the API Tools, but let me know what you'd like. "General Purpose Tools" sounds like a good fit, if that is the category you referring to. I'm guessing you'd want it to be > ... again, let me know, probably a new bug in Cross Project's component > would be best). We have a cross project component for bugs? Can you tell me what this is, I just search for "cross" on all bug components and found only one about modelling. The e4 tools are now included in the sim release. See Bug 464725. Thanks everybody for the help on this issue. A question : Does it mean that this page will disappear: http://download.eclipse.org/e4/downloads/ And where can we get the latest tooling for e4 now ? (In reply to Olivier Prouvost from comment #20) > A question : > > Does it mean that this page will disappear: > http://download.eclipse.org/e4/downloads/ > > And where can we get the latest tooling for e4 now ? Definitely via the Mars update site, but we should also have a daily update site for it. Created Bug 465047 for this. Part of http://download.eclipse.org/eclipse/updates/4.5, I assume it shows up in the Mars update side with the next milestone build. |