Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 459625

Summary: Oomph loads setup models at startup time even if "Skip auto task..." checked
Product: [Tools] Oomph Reporter: Axel RICHARD <axel.richard>
Component: SetupAssignee: Eike Stepper <stepper>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: axel.richard, dennis.huebner, Ed.Merks, gunnar, mknauer, stepper
Version: 1.1.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
"Explore" context menu contribution none

Description Axel RICHARD CLA 2015-02-11 04:36:21 EST
Hi,

I don't understand why, at startup time, the Oomph setup models are loaded even if the "Skip automatic task execution at startup time" is checked.
Indeed, at startup time, the progress bar (in the right bottom corner) shows the loading of setups models with messages like "Load : index:/org.eclipse.setup" and other ones.

May be the option "Skip automatic task execution at startup time" should disable "totally" oomph (avoid loading setup models) ?

Or mya be Oomph should provide another preference to disable itself "totally" ?

Regards,
Comment 1 Dennis Huebner CLA 2015-02-11 05:08:56 EST
Thanks for reporting.
oomph is inherited from the common feature, hence affects all the packages.
Moving  to standard-package.
Comment 2 Dennis Huebner CLA 2015-02-11 05:14:14 EST
Created attachment 250712 [details]
"Explore" context menu contribution

There is also an "Explore" context menu contribution in package explorer, which does nothing.

The active contribution item identifier:
org.eclipse.oomph.p2.ui.ExploreRepository
The active contribution location URI:
menu:null?after=org.eclipse.oomph.p2.ui.ExploreRepository
Comment 3 Eike Stepper CLA 2015-02-13 03:59:21 EST
Moving this to Oomph for investigation...
Comment 4 Eike Stepper CLA 2015-02-13 04:19:40 EST
(In reply to comment #2)
> "Explore" context menu contribution

I just tried this and couldn't reproduce it. On what element did you activate the context menu?
Comment 5 Eike Stepper CLA 2015-02-13 04:31:13 EST
(In reply to comment #0)
> May be the option "Skip automatic task execution at startup time" should disable
> "totally" oomph (avoid loading setup models) ?

I think now that Oomph is included into all packages it makes sense to think about this one. This is a very fundamental and sensible part of Oomph but I'll discuss it with Ed...
Comment 6 Dennis Huebner CLA 2015-02-13 04:37:40 EST
(In reply to Eike Stepper from comment #4)
> (In reply to comment #2)
> > "Explore" context menu contribution
> 
> I just tried this and couldn't reproduce it. On what element did you
> activate the context menu?

Tried with empty project explorer?
Comment 7 Eike Stepper CLA 2015-02-13 04:59:06 EST
Oh, now I see it :P
Comment 8 Eike Stepper CLA 2015-02-13 05:16:19 EST
Fixed the menu contributions for an empty selection: http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/commit/?id=01a9c6d44ca3dcd0ef5a2d9ca032f3cd7553385f
Comment 9 Eike Stepper CLA 2015-02-17 02:31:17 EST
Info: The mirror (the information computed) affects the items in the open/navigate menu.
Comment 10 Axel RICHARD CLA 2015-02-20 04:01:31 EST
(In reply to Eike Stepper from comment #5)
> (In reply to comment #0)
> > May be the option "Skip automatic task execution at startup time" should disable
> > "totally" oomph (avoid loading setup models) ?
> 
> I think now that Oomph is included into all packages it makes sense to think
> about this one. This is a very fundamental and sensible part of Oomph but
> I'll discuss it with Ed...

Hi Eike,

Do you had the time to discuss with Ed about this ?
Comment 11 Eike Stepper CLA 2015-02-20 04:24:25 EST
Yes, we hope to be able to address this for Mars M6.
Comment 12 Axel RICHARD CLA 2015-02-20 04:32:52 EST
(In reply to Eike Stepper from comment #11)
> Yes, we hope to be able to address this for Mars M6.

Great ! Thanks
Comment 13 Eike Stepper CLA 2015-03-18 14:15:32 EDT
Now we had time to discuss that again and it's in fact quite problematic for the Oomph UI to not have the resources available locally because all the Open menus are generated from that data. Can you please elaborate why this mirroring is so problematic for you?
Comment 14 Axel RICHARD CLA 2015-03-19 03:43:28 EDT
Hi Eike,

Thanks for your answer. It is not so problematic for me. I just see that, at startup time, the Oomph setup models are loaded even if the "Skip automatic task execution at startup time" is checked. This loading time is quite long, and in my humble opinion, a user who disabled Oomph shouldn't deals with the loading of Oomph setup models each time his Eclipse environment is running.
As far I know, Oomph will be part of (almost ?) all Eclipse packages from Mars, so It is important to give the best experience to the users. In my humble opinion, If a user want to disable Oomph, Ommph should be disable "totally".

What do you think about it ?

Thanks again.

Regards,
Comment 15 Eike Stepper CLA 2015-03-19 03:54:16 EDT
(In reply to Axel RICHARD from comment #14)
> and in my humble opinion, a user who disabled Oomph 

I think this is the fundamental misunderstanding: "Skip automatic task execution at startup time" does NOT mean "disable Oomph totally".

> If a user want to disable Oomph, Ommph should be disable "totally".

Currently disabling Oomph is not possible. I explained the reason in comment #13.

I think it's a little similar to the situation you're in when you installed an EPP package with JDT in it. It will always "Initialize Java Tooling" at startup time.
Comment 16 Axel RICHARD CLA 2015-03-19 04:09:46 EDT
Thanks for answers.

I initially raise this bug because I feel Eclipse is taking a long time to launch. For the user experience, any additional long process - as the loading of Oomph setup models - raise the feeling that Eclipse is very slow at startup.
That's why I have proposed the possibility to disable "totally" Oomph.
But I can understand that's not possible.

Thank you for your time.

Regards,
Comment 17 Eike Stepper CLA 2015-03-19 04:15:05 EDT
This initial mirroring happens in a job and should not contribute to the overall startup time of the IDE. Nevertheless I'm going to mark that job as a system job so that it is not visible anymore...