Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 459586

Summary:	Make *inf files consistent between SDK and Platform (binary and SDK)
Product:	[Eclipse Project] Platform	Reporter:	David Williams <david_williams>
Component:	Releng	Assignee:	David Williams <david_williams>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	arunkumar.thondapu, lshanmug
Version:	4.5
Target Milestone:	4.5 M6
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:
Bug Blocks:	434596

Description David Williams

2015-02-10 12:58:08 EST

While working on some other bugs, noticed that the *inf files between "Platform only" (binary and SDK) and not consistent with "Eclipse SDK". I think one or the other should change so they are consistent ... or (more likely, is my guess) removed, if they are "out of date" specifications. 

One thing that is inconsistent is that the sdk.p2.inf has 'set properties' for "useCario". I do not think that is required any longer? 

Another inconsistency is that in the 'SDK.p2.inf' we set properties for "aix.ppc". We use that to set the "max heap size" ... and we set it to what is in the platform definition. I think we'd only have to set it if we wanted something different for only that platform. (it was 512, changed to 1024, for bug 457489). 

There's a few others that I think "do not apply" related to osx platform.

Comment 1 David Williams

2015-02-10 13:06:21 EST

Arun, or Lakshmi, can you confirm? We no longer need to set "useCario" on Linux x86_64 platform's, right? I'm thinking this is just something "old" left over.

They do not seem to be set "in the product", so if needed, they would have to be "fixed" ... but ... my guess is simply not needed.

Comment 2 David Williams

2015-02-10 13:13:28 EST

This commit removes he "linux specific" part of SDK's p2.inf: 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=97d9f539d4bf4b29a8b116b8eb921682f3fdf5db


And this one removes the "aix.ppc" specific parts: 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=1098d1238d4faec98e76428964dc55495478c3a3

Comment 3 David Williams

2015-02-10 17:50:56 EST

There was another spot in "Platform" that had this "useCario" property set. 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=18846cdc6cc840bef57ed288ad4303bd022d59f0

Comment 4 David Williams

2015-02-10 18:03:42 EST

Between the fixes here, and the fixes in bug 457489, the 3 *p2.inf files are now consistent.

Comment 5 Arun Thondapu

2015-02-11 07:17:39 EST

(In reply to David Williams from comment #1)
> Arun, or Lakshmi, can you confirm? We no longer need to set "useCario" on
> Linux x86_64 platform's, right? I'm thinking this is just something "old"
> left over.
> 
> They do not seem to be set "in the product", so if needed, they would have
> to be "fixed" ... but ... my guess is simply not needed.

You're right David, it should not be necessary to set the useCairo parameter, it is anyway set by SWT based on the version of Cairo libraries found, not sure why it was added earlier but removing it should not be a problem IMO.