Bugzilla – Full Text Bug Listing
| Summary: | [console] Auto-scroll lock should not affect the view state | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Eike Stepper <stepper> | ||||||||
| Component: | Debug | Assignee: | Sarika Sinha <sarika.sinha> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | daniel_megert | ||||||||
| Version: | 4.5 | Flags: | daniel_megert:
pmc_approved+
daniel_megert: review- daniel_megert: review+ |
||||||||
| Target Milestone: | 4.5 M7 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows 7 | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | 149393 | ||||||||||
| Bug Blocks: | 459494 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Eike Stepper
Created attachment 251043 [details]
Auto scroll lock enabled per page
Now, Page wise scroll lock state is maintained. Auto scroll lock and manual scroll lock enabling is maintained separately. Changing the scroll lock state (auto or manual) does not impact the scroll lock state of other pages. User changes are remembered and used for next session.
Created attachment 251044 [details]
Auto scroll lock enabled per page
Removed the commented code.
(In reply to Sarika Sinha from comment #2) > Created attachment 251044 [details] [diff] > Auto scroll lock enabled per page > > Removed the commented code. The patch does not work: 1. start a program ==> writes to console, scrolls 2. lock by manually clicking the button ==> view is locked 3. wait until program is done or kill it 4. start a program ==> writes to console, BUG: scrolls even though the scroll lock icon says otherwise We need to find better names. The IScrollLockStateProvider interface is now very hard to understand. The concept of a page is not known by the provider. Maybe we can have *ScrollLock and *AutoScrollLock? Why do we need the auto-scroll methods/state in IOConsoleViewer? Created attachment 251391 [details]
Auto scroll lock enabled per page
IScrollLockStateProvider has now two methods now - scrollLock and AutoScrollLock. scrollLock for user setting the state manually and AutoScrollLock for scroll lock being set programatically based on user's actions
Why do we need the auto-scroll methods/state in IOConsoleViewer? - this was required for acting on documentChanged. Now due to name changes in the interface, AutoScroll will be used to act on document change.
(In reply to Sarika Sinha from comment #4) > Created attachment 251391 [details] [diff] > Auto scroll lock enabled per page I quickly tested the patch and first thought the patch introduces a new problem: the Console does not scroll when directly opened by the launch (i.e. view not yet open). However, this turned out to be an old issue that was already present in 3.8. I filed bug 462950 for that. (In reply to Sarika Sinha from comment #4) > Created attachment 251391 [details] [diff] > Auto scroll lock enabled per page > > IScrollLockStateProvider has now two methods now - scrollLock and > AutoScrollLock. scrollLock for user setting the state manually and > AutoScrollLock for scroll lock being set programatically based on user's > actions Looks good. The Javadoc can still be a little bit improved, but I'll do that after committing the patch. +1 for the API addition. Submitted patch with http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=2bb55ad088094656f8cda170f76cab29d1811c62 Verified using Eclipse SDK Version: Mars (4.5) Build id: N20150326-2000 |