Bugzilla – Full Text Bug Listing
| Summary: | Create new Git repository "eclipse.images" | ||
|---|---|---|---|
| Product: | Community | Reporter: | Lars Vogel <Lars.Vogel> |
| Component: | Git | Assignee: | Eclipse Webmaster <webmaster> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, denis.roy, Lars.Vogel, ma.becker, mikael.barbero |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://git.eclipse.org/r/54932 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 422139 | ||
|
Description
Lars Vogel
We https://bugs.eclipse.org/bugs/show_bug.cgi?id=422139#c13 for Danis and David statement (In reply to Lars Vogel from comment #0) > So +1 from platform.ui lead for creating this new repo called > "eclipse.images". The work is currently mainly done by platform.ui so it > would be good if platform.ui could "own" this repo. The repo would be for the Eclipse top-level project only. I suggest this: http://git.eclipse.org/c/platform/eclipse.images.git/ (In reply to Dani Megert from comment #2) > (In reply to Lars Vogel from comment #0) > > So +1 from platform.ui lead for creating this new repo called > > "eclipse.images". The work is currently mainly done by platform.ui so it > > would be good if platform.ui could "own" this repo. > > The repo would be for the Eclipse top-level project only. I suggest this: > > http://git.eclipse.org/c/platform/eclipse.images.git/ +1 Ok I've created /gitroot/platform/eclipse.images.git and have given it to the platform.ui team. Is there anything else? -M. (In reply to Eclipse Webmaster from comment #4) > Ok I've created /gitroot/platform/eclipse.images.git and have given it to > the platform.ui team. > > Is there anything else? > > -M. I guess we can start with platform.ui for now. Maybe at a later point more projects will need write access. That's why I initially suggested to use platform.common. (In reply to Eclipse Webmaster from comment #4) > Ok I've created /gitroot/platform/eclipse.images.git and have given it to > the platform.ui team. > > Is there anything else? > > -M. Can you also enable Gerrit for this repo? Direct pushes should also be allowed and the repo should set to "Fast Forward Merges only". (In reply to Lars Vogel from comment #6) > (In reply to Eclipse Webmaster from comment #4) > Can you also enable Gerrit for this repo? Direct pushes should also be > allowed and the repo should set to "Fast Forward Merges only". @Mikael can you activate Gerrit for the new repo? I am on my way back to France from Ottawa so I have scarce wifi. Will do it ASAP. This is done. FWIW Mikael, for platform repositories there are some ACLs that need to be applied to the filesystem since their definition of "push directly to the repo" means circumventing Gerrit altogether. gitroot/platform # setfacl -R -m d:u:gerrit:rwx eclipse.images.git gitroot/platform # setfacl -R -m u:gerrit:rwx eclipse.images.git For everyone else != platform project, the Gerrit user is the sole owner of the underlying filesystem, and "push directly to the repo" means granting Push on refs/heads/master (which is not a default permission. In this case, I've also set the project to inherit permissions from platform/eclipse.platform to allow feature branches. (In reply to Denis Roy from comment #9) > This is done. > > FWIW Mikael, for platform repositories there are some ACLs that need to be > applied to the filesystem since their definition of "push directly to the > repo" means circumventing Gerrit altogether. > > gitroot/platform # setfacl -R -m d:u:gerrit:rwx eclipse.images.git > gitroot/platform # setfacl -R -m u:gerrit:rwx eclipse.images.git > > For everyone else != platform project, the Gerrit user is the sole owner of > the underlying filesystem, and "push directly to the repo" means granting > Push on refs/heads/master (which is not a default permission. > > In this case, I've also set the project to inherit permissions from > platform/eclipse.platform to allow feature branches. Does the permission include the platform.ui developer? AFAIK I'm not part of the eclipse.platform project and I'm the one working mainly on this repo. Sorry, I missed that part from previous comments. I've set the parent to platform/eclipse.platform.ui (In reply to Denis Roy from comment #11) > I've set the parent to platform/eclipse.platform.ui Thanks Denis. Thanks Denis, I was not aware of this subtlety for the platform ;) New Gerrit change created: https://git.eclipse.org/r/54932 WARNING: this patchset contains 701033 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire Could it be that there's currently no automatic build for gerrit changes? My changes https://git.eclipse.org/r/#/c/54951/ and https://git.eclipse.org/r/#/c/54950/ are not picked up by the eclipse hudson server. The repo is also not visible on eclipse's github presence. (In reply to Matthias Becker from comment #15) > Could it be that there's currently no automatic build for gerrit changes? > My changes https://git.eclipse.org/r/#/c/54951/ and > https://git.eclipse.org/r/#/c/54950/ are not picked up by the eclipse hudson > server. > > The repo is also not visible on eclipse's github presence. So far we do not have a Gerrit build validation job for this repo (it was empty so far). If you think such a job is valuable, please open a bug for it and assign it to me. For the icon stored there I think we don't need this. But we also store there the PNG renderer. Was it built on it's old location? If yes we should have at least the same validation as in the old location. (In reply to Matthias Becker from comment #17) > But we also store > there the PNG renderer. Was it built on it's old location? If yes we should > have at least the same validation as in the old location. No, it was not build. |