| Summary: | [IE only] editor styles settings page is broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Grant Gayed <grant_gayed> | ||||
| Component: | Client | Assignee: | Umar Bolatov <ubolatov> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | grant_gayed | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 9.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
The problem is that IE does not support input elements with type "color". For now have removed this page from the settings if the client is IE (commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=77836e513839e03eb731eabb2a90a7cf6209aa73 ). A proper fix will be to either implement a custom color-picking solution for IE, or wait for it to become supported in a future IE release. New Gerrit change created: https://git.eclipse.org/r/43258 New Gerrit change created: https://git.eclipse.org/r/43264 The commit is pushed to master ( http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fd6d8864109757e1caba77703adecccb44cf8dd4 ) followed by another commit with some small tweaks ( http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fb607a622108525f5b6a3eec77517af6a6abca56 ). As a side note I had a hard time getting Gerrit to do the commit because there was a conflict, so I ended up not going through Gerrit ultimately. So I've removed the Gerrit links from this report and have abandoned them. Lastly, logged follow-up Bug 461604 - [IE only] editor styles page accepts and persists invalid colour strings . |
Created attachment 250546 [details] screenshot screenshot is attached