| Summary: | Implement new donor list page | ||
|---|---|---|---|
| Product: | Community | Reporter: | Edouard Poitras <edouard> |
| Component: | Website | Assignee: | phoenix.ui <phoenix.ui-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | chris.guindon, denis.roy, ian.skerrett, roxanne.joncas |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| URL: | http://https://www.eclipse.org/donate/donorlist.php | ||
| See Also: |
https://git.eclipse.org/r/42340 https://git.eclipse.org/r/45891 https://git.eclipse.org/c/www.eclipse.org/donate.git/commit/?id=fa695aca1883bc173b35a1ae12940ee91409fe50 https://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/commit/?id=478960d2a2ded1d3e16e713f8e5af64a63ba3bb9 |
||
| Whiteboard: | |||
|
Description
Edouard Poitras
New Gerrit change created: https://git.eclipse.org/r/42340 This is what it looks like so far [1] Should we add metrics/links from the existing page [2], such as the total donation numbers, legend, and the help links on the left hand side? [1] https://staging.eclipse.org/donate/donorlist.php [2] https://www.eclipse.org/donate/donorlist.php My only comment is that I'd expect "Next page" to be on the right, and Previous Page to be on the left. Other than that, I think it looks good. (In reply to Denis Roy from comment #3) > My only comment is that I'd expect "Next page" to be on the right, and > Previous Page to be on the left. Good call. It did look a bit weird. The changes should be reflected in a few minutes. This is done, right? (In reply to Denis Roy from comment #5) > This is done, right? Eddie told me that this is currently on staging and his patch is ready for review: https://git.eclipse.org/r/#/c/42340/ I think it looks OK ... let's push it through and close this. New Gerrit change created: https://git.eclipse.org/r/45891 Gerrit change https://git.eclipse.org/r/42340 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/donate.git/commit/?id=fa695aca1883bc173b35a1ae12940ee91409fe50 Gerrit change https://git.eclipse.org/r/45891 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/commit/?id=478960d2a2ded1d3e16e713f8e5af64a63ba3bb9 I finally managed to push this through. |