Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 459243

Summary: Ensure FXZoomOnPinchSpreadPolicy and FXZoomOnScrollPolicy provide similar zooming experience.
Product: [Tools] GEF Reporter: Alexander Nyßen <nyssen>
Component: GEF MVCAssignee: Matthias Wienand <matthias.wienand>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: matthias.wienand
Version: unspecified   
Target Milestone: 3.10.0 (Mars) M7   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Alexander Nyßen CLA 2015-02-05 12:16:03 EST
The scroll events that are created by pinch/spread gesture and mouse wheel scroll differ in their "stepping". That is, the y-delta between two succeeding scroll events is 40 when scrolling with the mouse wheel (at least on Mac), while it is 5 when using the pinch/spread gesture (we have chosen that fine-grained stepping within SwtToFXGestureConverter). This leads to the fact, that the "zooming speed" is different in both cases. We should ensure that the FXZoomOnScrollPolicy compensates the larger stepping properly, so that the experience is comparable in both cases.
Comment 1 Alexander Nyßen CLA 2015-02-09 12:47:12 EST
The zoom factor within the JavaFX zoom event that originates from an swt mouse event, seems to be computed by SWTEvents.getWheelRotation() and is platform specific.
Comment 2 Matthias Wienand CLA 2015-04-27 14:51:08 EDT
I increased the zoom velocity when zooming via the scroll wheel, so that it feels comparable to zooming via pinch and spread. The code is published on the master branch, therefore, I resolve this ticket as fixed for 3.10.0M7.