Bugzilla – Full Text Bug Listing
| Summary: | Update the login experience | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Paul Webster <pwebster> | ||||
| Component: | Client | Assignee: | Umar Bolatov <ubolatov> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ahunter.eclipse, antonm, curtis.windatt.public | ||||
| Version: | 8.0 | ||||||
| Target Milestone: | 9.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/41096 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=46a641aba2bc3069addbd9499ceac5a41f5696a5 https://git.eclipse.org/r/41657 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2c535da4f42acbd2f0db49e8236b723b1e9c9ae1 https://git.eclipse.org/r/42569 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6db7adc5889bee6e7a4bbbc72b050a36c4f5dc42 https://git.eclipse.org/r/43039 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=7406ca6c21d1c880a8135ba2976ae381efd7277a |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Paul Webster
Gerrit url https://git.eclipse.org/r/#/c/41096/ Gerrit change submitted: https://git.eclipse.org/r/41096 Gerrit change https://git.eclipse.org/r/41096 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=46a641aba2bc3069addbd9499ceac5a41f5696a5 Approving so it can be merged for further testing. However there are a few issues... why do we need another copy of require.js libraries check in here? We should be able to reference the existing libraries rather than make copies. Also the JQuery dependency is new. I would like to get rid of that, or at least understand why we need it. New Gerrit change created: https://git.eclipse.org/r/41657 WARNING: this patchset contains 1627 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire WARNING: this patchset contains 1627 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire Gerrit change https://git.eclipse.org/r/41657 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2c535da4f42acbd2f0db49e8236b723b1e9c9ae1 WARNING: this patchset contains 1627 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire I have pushed Umar's the latest changes to master. The previous version using https://orion.eclipse.org/mixloginstatic/secret/LoginWindow.html I can successfully login with the normal, github and google accounts. I cannot seem to login using normal and google accounts on my local machine at localhost:8080 but the github account works. I cannot seem to create a new account either. A few comments: 1) The shading does not work on the LoginWindow.html at 640x960. 2) http://orion.eclipse.org is hard coded in register.html and LoginWindow.html. Once I fix I could login using github. 3) Is the a reason for not using the latest JQuery 2.1.3? we are using 2.0.3. At this point to properly test we should refactor to the final place in a git branch. I have created a new branch ubolatov_new_landing in orion client. Can you refactor the new pages in the branch and get rid of the "secret" folder? We can then test out the latest code in the branch. Gerrit change https://git.eclipse.org/r/42569 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6db7adc5889bee6e7a4bbbc72b050a36c4f5dc42 (In reply to Anthony Hunter from comment #9) > At this point to properly test we should refactor to the final place in a > git branch. I have created a new branch ubolatov_new_landing in orion > client. Can you refactor the new pages in the branch and get rid of the > "secret" folder? > > We can then test out the latest code in the branch. Ok, next step is to refactor the new pages in the ubolatov_new_landing branch and get rid of the "secret" folder so we can test before we deliver this. New Gerrit change created: https://git.eclipse.org/r/43039 I have pushed the latest login code to the ubolatov_new_landing branch and done some testing with the new landing page at: http://localhost:8080/mixloginstatic/landing.html I have tested with email notification on against our oauth accounts and looks good now. I think we are good to push master, we should confirm in tomorrow's Orion status call. There is only a few additional comments below. Now that it is ready to deliver perhaps Anton and other committers should also test and comment. When you create a new oauth account, you are brought back to the new register.html page. I think the page needs to be more clear that we are now creating a new Orion account associated with your oauth account and hide the oauth buttons since you already clicked on them. The shading does not work all that well when I reduce to iPhone resolution in Chrome. I will attached a screen shot Created attachment 251226 [details]
Screen shot of the issue
Background shading is off at 640x970, which is supposedly an iPhone resolution.
WARNING: this patchset contains 1690 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire WARNING: this patchset contains 1690 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire Gerrit change https://git.eclipse.org/r/43039 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=7406ca6c21d1c880a8135ba2976ae381efd7277a WARNING: this patchset contains 1690 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire WARNING: this patchset contains 1690 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire I have reviewed the latest changes and I think we are good to go for orion.eclipse.org and orionhub.org. I propose we debug for the next week on orion.eclipse.org and push to a stable build next week to orionhub.org. I have pushed all the changes to master with commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=7406ca6c21d1c880a8135ba2976ae381efd7277a We are going to have to review for a default Orion download install though. We have now regressed when you run orion from an Orion download. It still navigates to the login page. It also says to check emails when by default email configuration is not required. All things considered, to get this feature completed, we are going to need to work in master. We can raise new bugs to get issues fixed. If any of the committers see any issues in the code, we need to flag these as well. Thanks to our last two students Aidan and Umar who have been working on this feature over many months and Anton for the considerable work on the UI side. |