Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 458655

Summary:	[Profile Applications] No graphics refresh and CSS rendering after loading a profile application
Product:	[Modeling] Papyrus	Reporter:	Toni Siljamäki <toni.siljamaki>
Component:	Diagram	Assignee:	Christian Damus <give.a.damus>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	give.a.damus, papyrus-bugs
Version:	1.1.0
Target Milestone:	M5
Hardware:	All
OS:	All
Whiteboard:	bbi deploy

Description Toni Siljamäki

2015-01-28 11:29:01 EST

This actually worked in the Mars nightly from 21 Jan, but not now.

The graphics CSS rendering of the diagram is based stereotypes and properties.
When unloading a profile application, the graphics does away, of course,
but the graphics does npt automatically get back when loading it again.

The PW protected attachment in Bug 458197 can be used for testing.
The work on this one should be synchronized with the work on the new CSS support.

NOTE: There _is_ a graphics refresh when loading a profile application
and after upgrading it to a new profile version.

Comment 1 Christian Damus

2015-01-28 11:54:14 EST

This, this is a regression caused by the fix for bug 436666 comment 47, in which stereotype repair now detects dangling stereotype instances.  To do this check, the stereotype repair function looks for the base_Xyz extension end reference in each stereotype instance.  That triggers proxy resolution before the TransactionChangeRecorder has found its way onto the stereotype application.  This means that the notifications sent out when the transaction commits won't include those proxy resolutions, so the StereotypeElementListener won't know about them and won't trigger refreshes of the affected diagram edit-parts.

A fix for this is included in the Gerrit patch for bug 458179:

    https://git.eclipse.org/r/#/c/40518/

Comment 2 Christian Damus

2015-01-29 15:43:15 EST

Fixed in Mars M5:  commit 72109763b62f13b750f14e25e1ca969cd9acf449

As the gerrit patch linked in comment 1 is proving controversial and the fix for this problem is simple and safe, I have extracted it and pushed it.

Neither the problem nor the solution depends on bug 458197, so I have removed that dependency.

Comment 3 Toni Siljamäki

2015-01-30 06:35:46 EST

Yep, this one work again. :)
Great and thanx.