Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 458523

Summary:	CommandContributionItem should be made final
Product:	[Eclipse Project] Platform	Reporter:	Andrey Loskutov <loskutov>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	major
Priority:	P3	CC:	Lars.Vogel
Version:	4.5
Target Milestone:	---
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=445538
Whiteboard:

Description Andrey Loskutov

2015-01-27 08:51:20 EST

Followup on bug 445538 fixes: the CommandContributionItem javadoc says that it should not be extended by clients, and after the fix for bug 445538 there will be no platform UI clients left who would need to subclass CommandContributionItem.

To make sure we do not have any unexpected side effects (see for example CoolBarToTrimManager.fill() code where CommandContributionItem are converted to HandledContributionItem and disposed after that), better and safer to make the class final.

Not sure if this change is breaking any existing Eclipse.org clients - if yes, they were violating the API contract anyway.

Comment 1 Andrey Loskutov

2015-01-27 08:54:11 EST

Fix: https://git.eclipse.org/r/40450

Comment 2 Lars Vogel

2015-01-27 10:07:58 EST

This would break client, I don't think we could do that.