Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 458088

Summary:

Broken NLS support for quickfixes (and probably more)

Product:

[ECD] Orion

Reporter:

Michael Rennie <Michael_Rennie>

Component:

Client

Assignee:

libing wang <libingw>

Status:

RESOLVED FIXED

QA Contact:

Severity:

critical

Priority:

CC:

emoffatt, mamacdon, simon_kaegi

Version:

8.0

Target Milestone:

8.0

Hardware:

OS:

Mac OS X

Whiteboard:

Attachments:

Description	Flags
screen shot	none
open related menu	none

Description Michael Rennie

2015-01-21 15:53:04 EST

Created attachment 250128 [details]
screen shot

Commit http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=08d95263a8001eb636eff9c1e3170e5ce5c9a1f3

broke support for NLS on quickfixes

Steps:
1. sync with master
2. launch target site
3. create JS problem (an unused param one will work)
4. hover over it.
5. you get the attached screen shot.

Comment 1 Eric Moffatt

2015-01-22 10:39:38 EST

LiBing and Simon are currently fixing this (it's a lot more than simply the qf's...

We should look out for their commit and test / close this if it fixes our issues...

Comment 2 Michael Rennie

2015-01-22 11:58:55 EST

There were a bunch of commits to fix this:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=8a37c52a407b879598b0e7bb450fb5c1504e2ffd

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b5b79ccb1e56d2be040eca004188367b3e21b0f4

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ec768648f4a4088db54284d90199a9a275990725

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2eac5565988668136fae48b56959ddf20a8cabe2

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=4c53e045f246ec97009d15c4861d76508601db4b

and a sample plugin to show how NLSing works in 8.0

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fb45c1158c23c426944e614ad6136cb1c9b3cab1

I'll leave this open until we complete a complete test pass to make sure all cases are fixed.

Comment 3 Michael Rennie

2015-01-22 14:08:01 EST

Created attachment 250156 [details]
open related menu

The commands in the open related menu are still busted

Comment 4 libing wang

2015-01-23 14:43:56 EST

(In reply to Michael Rennie from comment #3)
> Created attachment 250156 [details]
> open related menu
> 
> The commands in the open related menu are still busted

Fixed this with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c6bd4e611dab9312410c2d13a6260d4d1c002d2a

Comment 5 Michael Rennie

2015-01-27 10:44:32 EST

Found another broken case in the JS tests:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=de61768648c68a5640d36fc3c2b0cc97336b4924

oddly enough, the local failure is not reported during the build.

I haven't seen any more broken strings, so I'm going to mark this as fixed.

Comment 6 Mark Macdonald

2015-01-27 11:26:12 EST

(In reply to Michael Rennie from comment #5)
> oddly enough, the local failure is not reported during the build.

The client unit tests are not running at all right now. We're waiting on an upgrade to the CF environment before I can reenable them. Opened bug 458551 as a reminder to track this.